Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with non-admins being able to see the plugin menu item #21657

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Sep 28, 2023

Fixes an issue with non-Admins, e.g. Contributors, being able to see the "Plugins" menu item.

To test:

Follow the same testing steps as in wordpress-mobile/WordPress-Android#19241

Regression Notes

  1. Potential unintended areas of impact: blog menu
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 28, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@kean kean requested review from enejb and momo-ozawa September 28, 2023 20:46
@kean kean added this to the 23.4 milestone Sep 28, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21657-acf1199
Version23.3
Bundle IDorg.wordpress.alpha
Commitacf1199
App Center BuildWPiOS - One-Offs #7228
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21657-acf1199
Version23.3
Bundle IDcom.jetpack.alpha
Commitacf1199
App Center Buildjetpack-installable-builds #6270
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit f06664d into trunk Sep 29, 2023
@kean kean deleted the fix/contributor-sees-plugin-menu-item branch September 29, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants