Fix MRProgressView compiling issue #21235
Conversation
Podfile
Outdated
| # We are going to replace the `id` with `MRProgressView *` (or any other type that has a method `setProgress:` that takes a float argument). | ||
| mrprogress_filepath = "#{project_root}/Pods/MRProgress/src/Components/MRProgressOverlayView.m" | ||
| File.chmod(0o644, mrprogress_filepath) | ||
| lines = IO.readlines(mrprogress_filepath) |
There was a problem hiding this comment.
| 🚫 | File.readlines is safer than IO.readlines. |
Podfile
Outdated
| lines = IO.readlines(mrprogress_filepath) | ||
| if lines[810] == " [((id)self.modeView) setProgress:self.progress];\n" | ||
| lines[810] = " [((MRProgressView *)self.modeView) setProgress:self.progress];\n" | ||
| IO.write(mrprogress_filepath, lines.join) |
There was a problem hiding this comment.
| 🚫 | File.write is safer than IO.write. |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21235-a3a43be | |
| Version | 22.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a3a43be | |
| App Center Build | jetpack-installable-builds #5659 |
| if lines[810] == " [((id)self.modeView) setProgress:self.progress];\n" | ||
| lines[810] = " [((MRProgressView *)self.modeView) setProgress:self.progress];\n" | ||
| File.write(mrprogress_filepath, lines.join) | ||
| end |
There was a problem hiding this comment.
This is a nifty way of patching the issue 🤓
Have you considered forking the repo? Might set us up for addressing future issues.
There was a problem hiding this comment.
That didn't cross my mind. 🥲
But I did think about removing this library, because it's only used in one single place: showing an activity indicator during uploading a featured image to a post's settings. I got lazy and decided to make this one line change instead. 😸
There was a problem hiding this comment.
😄
I came here to write the same thing. I found that same as you did (sigh of relief).
If we go in with the intention of removing this library, then I'd say it's okay to merge this approach. I wonder if we could get the help of some iOS UI dev 🤓
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21235-a3a43be | |
| Version | 22.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a3a43be | |
| App Center Build | WPiOS - One-Offs #6624 |
| if lines[810] == " [((id)self.modeView) setProgress:self.progress];\n" | ||
| lines[810] = " [((MRProgressView *)self.modeView) setProgress:self.progress];\n" | ||
| File.write(mrprogress_filepath, lines.join) | ||
| end |
There was a problem hiding this comment.
😄
I came here to write the same thing. I found that same as you did (sigh of relief).
If we go in with the intention of removing this library, then I'd say it's okay to merge this approach. I wonder if we could get the help of some iOS UI dev 🤓
The library hasn't published an update in 7 years, I doubt there will be an update now to fix this compiling issue.
mokagio
force-pushed
the
tonyli-xcode-15-fixes
branch
from
f8ca022 to
a3a43be
Compare
Generated by 🚫 dangerJS |
The library hasn't published an update in 7 years, I doubt there will be an update now to fix this compiling issue.
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A