Refactor SharingService to use CoreDataStack
#20265
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| extension PublicizeService { | ||
| /// Finds a cached `PublicizeService` matching the specified service name. | ||
| /// | ||
| /// - Parameter name: The name of the service. This is the `serviceID` attribute for a `PublicizeService` object. | ||
| /// | ||
| /// - Returns: The requested `PublicizeService` or nil. | ||
| /// | ||
| static func lookupPublicizeServiceNamed(_ name: String, in context: NSManagedObjectContext) throws -> PublicizeService? { | ||
| let request = NSFetchRequest<PublicizeService>(entityName: PublicizeService.classNameWithoutNamespaces()) | ||
| request.predicate = NSPredicate(format: "serviceID = %@", name) | ||
| return try context.fetch(request).first | ||
| } | ||
|
|
||
| @objc(lookupPublicizeServiceNamed:inContext:) | ||
| static func objc_lookupPublicizeServiceNamed(_ name: String, in context: NSManagedObjectContext) -> PublicizeService? { | ||
| try? lookupPublicizeServiceNamed(name, in: context) | ||
|
There was a problem hiding this comment. LOL. I just commented above about the code being better because it doesn't return Of course, this is a special case method, behaving that way to fit with the Objective-C layer 😄 There was a problem hiding this comment. Yeah, a little compromise for Objective-C code. |
||
| } | ||
|
|
||
| /// Returns an array of all cached `PublicizeService` objects. | ||
| /// | ||
| /// - Returns: An array of `PublicizeService`. The array is empty if no objects are cached. | ||
| /// | ||
| @objc(allPublicizeServicesInContext:error:) | ||
| static func allPublicizeServices(in context: NSManagedObjectContext) throws -> [PublicizeService] { | ||
| let request = NSFetchRequest<PublicizeService>(entityName: PublicizeService.classNameWithoutNamespaces()) | ||
| let sortDescriptor = NSSortDescriptor(key: "order", ascending: true) | ||
| request.sortDescriptors = [sortDescriptor] | ||
| return try context.fetch(request) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| extension SharingButton { | ||
|
|
||
| /// Returns an array of all cached `SharingButtons` objects. | ||
| /// | ||
| /// - Returns: An array of `SharingButton`s. The array is empty if no objects are cached. | ||
| /// | ||
| @objc(allSharingButtonsForBlog:inContext:error:) | ||
| static func allSharingButtons(for blog: Blog, in context: NSManagedObjectContext) throws -> [SharingButton] { | ||
| let request = NSFetchRequest<SharingButton>(entityName: SharingButton.classNameWithoutNamespaces()) | ||
| request.predicate = NSPredicate(format: "blog = %@", blog) | ||
| request.sortDescriptors = [NSSortDescriptor(key: "order", ascending: true)] | ||
| return try context.fetch(request) | ||
| } | ||
|
|
||
| /// Finds a cached `SharingButton` by its `buttonID` for the specified `Blog` | ||
| /// | ||
| /// - Parameters: | ||
| /// - buttonID: The button ID of the `SharingButton`. | ||
| /// - blog: The blog that owns the sharing button. | ||
| /// | ||
| /// - Returns: The requested `SharingButton` or nil. | ||
| /// | ||
| static func lookupSharingButton(byID buttonID: String, for blog: Blog, in context: NSManagedObjectContext) throws -> SharingButton? { | ||
| let request = NSFetchRequest<SharingButton>(entityName: SharingButton.classNameWithoutNamespaces()) | ||
| request.predicate = NSPredicate(format: "buttonID = %@ AND blog = %@", buttonID, blog) | ||
| return try context.fetch(request).first | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I called this out before, but one great benefit of all this work is how much more Swifty the code is getting by leveraging
throwsin many more places as opposed to swallowing errors or return.noneas a sign of error.