Remove activity logs after logging out

[staskus]

Fixes #19913

Description

We do not delete activity logs when logging out.

Handling 2 cases:

• Logging out of WP.com site
• Removing self-hosted site

Testing instructions

Case 1: WP.com accounts:

1. Launch the app and log in.
2. Use the app for a while.
3. Log out and log in with a different account.
4. Open Me screen by tapping your profile icon on the top of the screen.
5. Tap "Help & Support"
6. Tap "Activity Logs".
7. Look inside your saved logs and confirm your logs from your logged-out account are not visible

Case 2: Self-hosted site

1. Launch the app and log in to a self-hosted site with no .com account
2. Use the app for a while.
3. "Remove site" and log in with a different account
4. Open Me screen by tapping your profile icon on the top of the screen.
5. Tap "Help & Support"
6. Tap "Activity Logs".
7. Look inside your saved logs and confirm your logs from your remoted self-hosted site are not visible

Case 3: Multiple sites, removing self-hosted site when more sites are available

1. Launch the app and log in
2. Add self-hosted site
3. Use the app for a while.
4. Remove self-hosted site, the app switches to another account
5. Open Me screen by tapping your profile icon on the top of the screen.
6. Tap "Help & Support"
7. Tap "Activity Logs".
8. Look inside your saved logs and confirm that logs are visible

Regression Notes

1. Potential unintended areas of impact

Disrupting logout or site removal flows

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Manually testing that account logout and site removal process continue working smoothly. Inspecting activity logs.

4. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19930-b3a1770 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19930-b3a1770 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[sla8c]

@staskus LGTM and nice refactor + encapsulation into functions! 👍

[irfano]

All tests passed. ✅
Do we keep removed site logs in case 3 on purpose? I think we can remove them if it's easy to filter logs related to the removed site.

[staskus]

Do we keep removed site logs in case 3 on purpose? I think we can remove them if it's easy to filter logs related to the removed site.

@irfano thanks for testing! Not on purpose. We don't filter these activity logs by blogs, so if we switch between sites, we will have one set of logs. Case 3 was to make sure that all logs are not deleted by accident only when one site is removed but account remains logged in.