Fix unresponsive "Onboarding Questions" screen

[salimbraksa]

Fixes #19774

Description

This PR resolves an issue that was causing the user to get stuck in the "Onboarding Questions" screen.

Before	After
bug.mp4	CleanShot.2022-12-23.at.16.13.01.mp4

Related PR

• Fix unresponsive issue in Onboading Questions screen WordPressAuthenticator-iOS#719

Test Instructions

Prerequisites

Account Setup

Have an account with at least 2 sites and 2FA enabled.

Simulate Auth Token Issue

1. Log into your account.
2. Go to WPAuthTokenIssueSolver.m file and change hasAuthTokenIssues to return true

- (BOOL)hasAuthTokenIssues
{
//    NSManagedObjectContext *context = [[ContextManager sharedInstance] mainContext];
//    WPAccount *account = [WPAccount lookupDefaultWordPressComAccountInContext:context];
//
//    BOOL hasAuthTokenIssues = account && ![account authToken];
//
//    return hasAuthTokenIssues;
    return true;
}

3. Build and run the WordPress app
4. Expect the Log In screen to appear

1. Follow Prerequisites steps
2. Enter your password
3. Expect the 2FA screen to appear
4. Enter 2FA code, then tap Continue
5. Expect the Blogs List screen to appear
6. Select any blog
7. Expect the “What would you like to focus on first?” screen to appear
8. Tap any button
9. Expect the next screen to show up

Regression Notes

1. Potential unintended areas of impact
   None.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   None.

3. What automated tests I added (or what prevented me from doing so)
   None.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19791-ce5dbc5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19791-ce5dbc5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[twstokes]

This worked great! I also approved wordpress-mobile/WordPressAuthenticator-iOS#719 (review). 🚀

For the pod to get pulled down I had to specify the commit hash rather than the branch. It looks like the branch name is out of sync and still pointing to 98dc0b8 instead of 03e2e89 that was force-pushed.

That should get ironed out once the merging / tagging takes place on the WordPressAuthenticator side.

I'd also consider a release note for this. 👍

[peril-wordpress-mobile]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[mokagio]

Since this PR was approved and the auto-merged enabled, the RELEASE-NOTES.txt developed conflicts.

I resolved them (with GitHub's web editor, for a change) and am now waiting for the auto-merge to kick in before starting the 21.6 code freeze.