Jetpack Focus: Disable WordPress app notifications from Jetpack app by using URL schemes

RELEASE-NOTES.txt

@@ -1,7 +1,6 @@
 21.3
 -----
-* [*] [internal] Blogging Reminders notifications and scheduling can be turned off for WordPress as part of Jetpack focus behind a feature flag. [#19611]
-* [*] [internal] Weekly Roundup notifications and scheduling can be turned off for WordPress as part of Jetpack focus behind a feature flag. [#19590]
+* [*] [internal] When a user migrates to the Jetpack app and allows notifications, WordPress app notifications are disabled. This is released disabled and is behind a feature flag. [#19616, #19611, #19590]
 * [*] Fixed a minor UI issue where the segmented control under My SIte was being clipped when "Home" is selected. [#19595]
 
 21.2

WordPress/Classes/Models/Blog+Capabilities.swift

@@ -66,6 +66,6 @@ extension Blog {
     }
 
     public func areBloggingRemindersAllowed() -> Bool {
-        return Feature.enabled(.bloggingReminders) && isUserCapableOf(.EditPosts)
+        return Feature.enabled(.bloggingReminders) && isUserCapableOf(.EditPosts) && JetpackNotificationMigrationService.shared.shouldPresentNotifications()
     }
 }

WordPress/Classes/Models/Notifications/NotificationSettings.swift

@@ -142,7 +142,7 @@ open class NotificationSettings {
     fileprivate var blogPreferenceKeys: [String] {
         var keys = [Keys.commentAdded, Keys.commentLiked, Keys.postLiked, Keys.follower, Keys.achievement, Keys.mention]
 
-        if Feature.enabled(.weeklyRoundup) {
+        if Feature.enabled(.weeklyRoundup) && JetpackNotificationMigrationService.shared.shouldPresentNotifications() {
             keys.append(Keys.weeklyRoundup)
         }
 

WordPress/Classes/Services/JetpackNotificationMigrationService.swift

@@ -0,0 +1,149 @@
+import UIKit
+
+protocol JetpackNotificationMigrationServiceProtocol {
+    func shouldPresentNotifications() -> Bool
+}
+
+/// The service is created to support disabling WordPress notifications when Jetpack app enables notifications
+/// The service uses URLScheme to determine from Jetpack app if WordPress app is installed, open it, disable notifications and come back to Jetpack app
+/// This is a temporary solution to avoid duplicate notifications during the migration process from WordPress to Jetpack app
+/// This service and its usage can be deleted once the migration is done
+final class JetpackNotificationMigrationService: JetpackNotificationMigrationServiceProtocol {
+    private let notificationSettingsLoader: NotificationSettingsLoader
+    private let remoteNotificationRegister: RemoteNotificationRegister
+    private var notificationsEnabled: Bool = false
+    private let isWordPress: Bool
+
+    static let shared = JetpackNotificationMigrationService()
+
+    static let wordPressScheme = "wordpressnotificationmigration"
+    static let jetpackScheme = "jetpacknotificationmigration"
+
+    var wordPressNotificationsEnabled: Bool {
+        get {
+            return remoteNotificationRegister.isRegisteredForRemoteNotifications
+        }
+
+        set {
+            if newValue, isWordPress {
+                remoteNotificationRegister.registerForRemoteNotifications()
+            } else if isWordPress {
+                remoteNotificationRegister.unregisterForRemoteNotifications()
+            }
+
+            if isWordPress && !newValue {
+                cancelAllPendingWordPressLocalNotifications()
+            }
+        }
+    }
+
+    /// Migration is supported if WordPress is compatible with the notification migration URLScheme
+    var isMigrationSupported: Bool {
+        guard let url = URL(string: "\(JetpackNotificationMigrationService.wordPressScheme)://") else {
+            return false
+        }
+
+        return UIApplication.shared.canOpenURL(url)
+    }
+
+    init(notificationSettingsLoader: NotificationSettingsLoader = UNUserNotificationCenter.current(),
+         remoteNotificationRegister: RemoteNotificationRegister = UIApplication.shared,
+         isWordPress: Bool = AppConfiguration.isWordPress) {
+        self.notificationSettingsLoader = notificationSettingsLoader
+        self.remoteNotificationRegister = remoteNotificationRegister
+        self.isWordPress = isWordPress
+
+        notificationSettingsLoader.getNotificationAuthorizationStatus { [weak self] status in
+            self?.notificationsEnabled = status == .authorized
+        }
+    }
+
+    func shouldShowNotificationControl() -> Bool {
+        return Feature.enabled(.jetpackMigrationPreventDuplicateNotifications) && isWordPress && notificationsEnabled
+    }
+
+
+    func shouldPresentNotifications() -> Bool {
+        let disableNotifications = Feature.enabled(.jetpackMigrationPreventDuplicateNotifications)
+            && isWordPress
+            && !wordPressNotificationsEnabled
+
+        if disableNotifications {
+            cancelAllPendingWordPressLocalNotifications()
+        }
+
+        return !disableNotifications
+    }
+
+    // MARK: - Only executed on Jetpack app
+
+    func disableWordPressNotificationsFromJetpack() {
+        guard Feature.enabled(.jetpackMigrationPreventDuplicateNotifications), !isWordPress else {
+            return
+        }
+
+        let wordPressUrl: URL? = {
+            var components = URLComponents()
+            components.scheme = JetpackNotificationMigrationService.wordPressScheme
+            return components.url
+        }()
+
+        /// Open WordPress app to disable notifications
+        if let url = wordPressUrl, UIApplication.shared.canOpenURL(url) {
+            UIApplication.shared.open(url)
+        }
+    }
+
+    // MARK: - Only executed on WordPress app
+
+    func handleNotificationMigrationOnWordPress() -> Bool {
+        guard isWordPress else {
+            return false
+        }
+
+        wordPressNotificationsEnabled = false
+
+        let jetpackUrl: URL? = {
+            var components = URLComponents()
+            components.scheme = JetpackNotificationMigrationService.jetpackScheme
+            return components.url
+        }()
+
+        /// Return to Jetpack app
+        if let url = jetpackUrl, UIApplication.shared.canOpenURL(url) {
+            UIApplication.shared.open(url)
+        }
+
+        return true
+    }
+
+    // MARK: - Local notifications
+
+    private func cancelAllPendingWordPressLocalNotifications(notificationCenter: UNUserNotificationCenter = UNUserNotificationCenter.current()) {
+        if isWordPress {
+            notificationCenter.removeAllPendingNotificationRequests()
+        }
+    }
+}
+
+// MARK: - Helpers
+
+protocol NotificationSettingsLoader: AnyObject {
+    func getNotificationAuthorizationStatus(completionHandler: @escaping (UNAuthorizationStatus) -> Void)
+}
+
+extension UNUserNotificationCenter: NotificationSettingsLoader {
+    func getNotificationAuthorizationStatus(completionHandler: @escaping (UNAuthorizationStatus) -> Void) {
+        getNotificationSettings { settings in
+            completionHandler(settings.authorizationStatus)
+        }
+    }
+}
+
+protocol RemoteNotificationRegister {
+    func registerForRemoteNotifications()
+    func unregisterForRemoteNotifications()
+    var isRegisteredForRemoteNotifications: Bool { get }
+}
+
+extension UIApplication: RemoteNotificationRegister {}

WordPress/Classes/System/Constants.h

@@ -41,7 +41,6 @@ extern NSString *const WPNotificationServiceExtensionKeychainServiceName;
 extern NSString *const WPNotificationServiceExtensionKeychainTokenKey;
 extern NSString *const WPNotificationServiceExtensionKeychainUsernameKey;
 extern NSString *const WPNotificationServiceExtensionKeychainUserIDKey;
-extern NSString *const WPNotificationsEnabledKey;
 
 /// Share Extension Constants
 ///

WordPress/Classes/System/Constants.m

@@ -47,7 +47,6 @@
 NSString *const WPNotificationServiceExtensionKeychainTokenKey      = @"OAuth2Token";
 NSString *const WPNotificationServiceExtensionKeychainUsernameKey   = @"Username";
 NSString *const WPNotificationServiceExtensionKeychainUserIDKey     = @"UserID";
-NSString *const WPNotificationsEnabledKey                           = @"WordPressNotificationsEnabled";
 
 /// Share Extension Constants
 ///

WordPress/Classes/System/WordPressAppDelegate+openURL.swift

@@ -20,6 +20,10 @@ import AutomatticTracks
             return true
         }
 
+        if url.scheme == JetpackNotificationMigrationService.wordPressScheme {
+            return JetpackNotificationMigrationService.shared.handleNotificationMigrationOnWordPress()
+        }
+
         guard url.scheme == WPComScheme else {
             return false
         }

WordPress/Classes/Utility/BackgroundTasks/BackgroundTasksCoordinator.swift

@@ -93,7 +93,7 @@ class BackgroundTasksCoordinator {
             }
 
             scheduler.register(forTaskWithIdentifier: type(of: task).identifier, using: nil) { osTask in
-                guard Feature.enabled(.weeklyRoundup) else {
+                guard Feature.enabled(.weeklyRoundup) && JetpackNotificationMigrationService.shared.shouldPresentNotifications() else {
                     osTask.setTaskCompleted(success: false)
                     eventHandler.handle(.taskCompleted(identifier: type(of: task).identifier, cancelled: true))
                     return

WordPress/Classes/Utility/BackgroundTasks/WeeklyRoundupBackgroundTask.swift

@@ -252,7 +252,7 @@ class WeeklyRoundupBackgroundTask: BackgroundTask {
     private let eventTracker: NotificationEventTracker
     let runDateComponents: DateComponents
     let notificationScheduler: WeeklyRoundupNotificationScheduler
-    private let notificationFilteringService = NotificationFilteringService()
+    private let jetpackNotificationMigrationService = JetpackNotificationMigrationService()
 
     init(
         eventTracker: NotificationEventTracker = NotificationEventTracker(),
@@ -262,7 +262,7 @@ class WeeklyRoundupBackgroundTask: BackgroundTask {
 
         self.eventTracker = eventTracker
         notificationScheduler = WeeklyRoundupNotificationScheduler(staticNotificationDateComponents: staticNotificationDateComponents,
-                                                                   notificationFilteringService: notificationFilteringService)
+                                                                   jetpackNotificationMigrationService: jetpackNotificationMigrationService)
         self.store = store
 
         self.runDateComponents = runDateComponents ?? {
@@ -361,7 +361,7 @@ class WeeklyRoundupBackgroundTask: BackgroundTask {
 
         // This will no longer run for WordPress as part of JetPack migration.
         // This can be removed once JetPack migration is complete.
-        if notificationFilteringService.shouldFilterWordPressNotifications() {
+        guard jetpackNotificationMigrationService.shouldPresentNotifications() else {
             notificationScheduler.cancellAll()
             notificationScheduler.cancelStaticNotification()
             return
@@ -495,11 +495,11 @@ class WeeklyRoundupNotificationScheduler {
 
     init(
         staticNotificationDateComponents: DateComponents? = nil,
-        notificationFilteringService: NotificationFilteringService,
+        jetpackNotificationMigrationService: JetpackNotificationMigrationService,
         userNotificationCenter: UNUserNotificationCenter = UNUserNotificationCenter.current()) {
 
         self.userNotificationCenter = userNotificationCenter
-        self.notificationFilteringService = notificationFilteringService
+        self.jetpackNotificationMigrationService = jetpackNotificationMigrationService
 
         self.staticNotificationDateComponents = staticNotificationDateComponents ?? {
             var dateComponents = DateComponents()
@@ -518,7 +518,7 @@ class WeeklyRoundupNotificationScheduler {
 
     let staticNotificationDateComponents: DateComponents
     let userNotificationCenter: UNUserNotificationCenter
-    let notificationFilteringService: NotificationFilteringService
+    let jetpackNotificationMigrationService: JetpackNotificationMigrationService
 
     enum NotificationSchedulingError: Error {
         case staticNotificationSchedulingError(error: Error)
@@ -624,7 +624,7 @@ class WeeklyRoundupNotificationScheduler {
         dateComponents: DateComponents,
         completion: @escaping (Result<Void, Error>) -> Void) {
 
-        if notificationFilteringService.shouldFilterWordPressNotifications() {
+        guard jetpackNotificationMigrationService.shouldPresentNotifications() else {
             return
         }