Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Social: Update the jetpack social sharing #19262

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Aug 31, 2022

Updates the Apps to have make Jetpack Social more predominant in the apps.
See pdrWKz-vt-p2

To test:

Go to Site > Settings > Sharing
Notice the new label.
Add a social account. Notice it says share post to %.

Go create a new post.
Select Post settings.
Notice it says Jetpack Social as a heading for the social connections.

Regression Notes

  1. Potential unintended areas of impact
    No regressions this is a text change only.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I looked at the UI in the.

  3. What automated tests I added (or what prevented me from doing so)
    none.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@enejb enejb added the Jetpack label Aug 31, 2022
@enejb enejb self-assigned this Aug 31, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 31, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19262-7f5264a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 31, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19262-7f5264a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@enejb enejb added this to the 20.7 milestone Aug 31, 2022
Copy link
Contributor

@hassaanelgarem hassaanelgarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Jetpack and WordPress.
Works as described 🚀

@enejb enejb merged commit 064eb1b into trunk Sep 2, 2022
@enejb enejb deleted the update/social-connection-to-jetpack-social branch September 2, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants