Onboarding Improvements: Epilogue (select site / create a new site) + Quick Start prompt

[momo-ozawa]

Fixes #17383

Description

This PR merges the feature branch for the Onboarding Improvements project into develop

Ref: pbArwn-35A-p2

How to test

Follow testing directions from:

• Onboarding Improvements: Select site from Epilogue #17411
• Onboarding Improvements: Epilogue screen create new site #17449
• Onboarding Improvements: Update quickstart copy #17484

Case	JP iPhone	WP iPhone	WP iPad
No sites
1-3 sites
4+ sites

Regression Notes

1. Potential unintended areas of impact

• Login Epilogue flow
• Quick Start
• Site creation

2. What I did to test those areas of impact (or what existing automated tests I relied on)

• Tested the flows above manually

3. What automated tests I added (or what prevented me from doing so)

• Added UI tests Onboarding Improvements: Fix UI tests #17561

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger an installable build for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[leandroalonso]

@momo-ozawa I found one small issue that doesn't prevent this to be merged on develop (I'd say it's an edge case). Basically, when the user is logged in and adds a self-hosted site we show the epilogue to them.

Steps to reproduce

1. Login
2. Add a self-hosted site
3. Notice that the epilogue is show (asking the user to select a site or to create a new one)
4. The prompt is displayed

[momo-ozawa]

@leandroalonso (cc: @osullivanchris)

I found one small issue that doesn't prevent this to be merged on develop (I'd say it's an edge case). Basically, when the user is logged in and adds a self-hosted site we show the epilogue to them.

Do you think it would make the most sense to just dismiss the login vc and go back to mysite w/o showing the epilogue?
FWIW, in 18.7 we show the epilogue after adding a self-hosted site. But given the new epilogue designs, it doesn’t make much sense to show a choose site / create a new site option.

[leandroalonso]

Do you think it would make the most sense to just dismiss the login vc and go back to mysite w/o showing the epilogue?

I guess so, yes. Unless it's super complicated!

[osullivanchris]

Good spot @leandroalonso . Proposed solution sounds good to me 👍

[AliSoftware]

Kudos @momo-ozawa for testing and including screenshots to JPiOS (and not just WP) 👏 , which already answers the question I almost had when drafting the release notes: with the clear PR description and screenshots I know without a doubt that this does apply to both WP and JP (and should thus be included in JP release notes too) 🙇 🎉