-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty stats: Publicize nudge dismissal logic #17294
Empty stats: Publicize nudge dismissal logic #17294
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm!
Left one small comment.
@@ -87,7 +88,7 @@ class GrowAudienceCell: UITableViewCell, NibLoadable { | |||
return | |||
} | |||
|
|||
updateView(isCompleted: true) | |||
// updateView(isCompleted: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we keep this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thank you!
1c5b920
into
draft/empty-stats-publicize-and-blogging-reminders
Part of #17215
This PR fixes Publicize nudge dismissal logic, so now publicize card is dismissed if the user has actually completed the step.
To test
Happy flow
Unhappy flow
Screnshots
Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.