Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty stats: Publicize nudge dismissal logic #17294

Conversation

nikola-milicevic
Copy link
Contributor

@nikola-milicevic nikola-milicevic commented Oct 11, 2021

Part of #17215

This PR fixes Publicize nudge dismissal logic, so now publicize card is dismissed if the user has actually completed the step.

To test

Happy flow

  1. Select the site that has less than 30 views
  2. Go to My Site > Stats
  3. Publizice nudge should be presented
  4. Tap on Enable post sharing and add new connection
  5. Go back to Stats screen
  6. Confirm Sharing is set up! message is displayed

Unhappy flow

  1. Repeat the steps 1, 2, 3
  2. Tap on Enable post sharing and don't add a new connection, or remove the existing one
  3. Go back to Stats screen
  4. Confirm Sharing is set up! message is not displayed

Screnshots

Sharing not set up Sharing set up
Screenshot 2021-10-12 at 10 04 22 Screenshot 2021-10-12 at 10 04 16

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 11, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@nikola-milicevic nikola-milicevic self-assigned this Oct 11, 2021
@nikola-milicevic nikola-milicevic marked this pull request as ready for review October 12, 2021 11:14
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 12, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

Left one small comment.

@@ -87,7 +88,7 @@ class GrowAudienceCell: UITableViewCell, NibLoadable {
return
}

updateView(isCompleted: true)
// updateView(isCompleted: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we keep this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you!

@nikola-milicevic nikola-milicevic merged commit 1c5b920 into draft/empty-stats-publicize-and-blogging-reminders Oct 12, 2021
@nikola-milicevic nikola-milicevic deleted the task/empty-stats-publicize-nudge-dismissal-logic branch October 12, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants