Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Moderation Bar: update comment when Approved button tapped. #17267

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Oct 6, 2021

Ref: #17200

When the Approved button is tapped on the moderation bar, the comment status is now updated.

  • A success message appears when successful.
  • When unsuccessful, a failure message appears and the button states are reset.
  • A No Connection alert is displayed if there is no internet connection.

To test:

  • Enable the newCommentDetail feature.
  • Go to My Site > Comments.
  • Select a comment that is not approved.
  • Select Approved on the moderation bar.
  • Verify a success message is displayed.
  • Go back to the comments list, and select the Approved filter.
  • Verify the comment appears in the list.
approve.mp4

Regression Notes

  1. Potential unintended areas of impact
    N/A. Feature is incomplete.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A. Feature is incomplete.

  3. What automated tests I added (or what prevented me from doing so)
    N/A. Feature is incomplete.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris requested a review from dvdchr October 6, 2021 00:20
@ScoutHarris ScoutHarris marked this pull request as ready for review October 6, 2021 00:20
@ScoutHarris ScoutHarris mentioned this pull request Oct 6, 2021
23 tasks
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ScoutHarris
Copy link
Contributor Author

Thanks @dvdchr !

@ScoutHarris ScoutHarris merged commit db6a2ae into develop Oct 6, 2021
@ScoutHarris ScoutHarris deleted the feature/17200-approve_action branch October 6, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants