Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg][Embed block] Include Jetpack embed variants #17224

Merged
merged 9 commits into from
Oct 6, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Sep 27, 2021

To test:
Follow testing instructions from wordpress-mobile/gutenberg-mobile#4008.

NOTE: Only the Instagram embed variant shows up in the block picker when using the installable build, the rest can be tested via the slash inserter.

Regression Notes

  1. Potential unintended areas of impact
    The only expected area of impact is the editor and its initialization process.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Smoke testing the editor, specifically the following parts:

  • Editor initialization
  • Block picker
  • Slash inserter
  • Jetpack blocks
  1. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Sep 27, 2021
@fluiddot fluiddot self-assigned this Sep 27, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 27, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 27, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@fluiddot fluiddot marked this pull request as ready for review September 28, 2021 16:58
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes @fluiddot I have verified that the respective embed blocks work as expected via wordpress-mobile/gutenberg-mobile#4008 (review)

@fluiddot fluiddot added this to the 18.5 milestone Oct 6, 2021
@fluiddot fluiddot enabled auto-merge October 6, 2021 18:44
@fluiddot fluiddot merged commit 887c65e into develop Oct 6, 2021
@fluiddot fluiddot deleted the gutenberg/embed-block-jetpack-variants branch October 6, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants