-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg][Embed block] Include Jetpack embed variants #17224
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @fluiddot I have verified that the respective embed blocks work as expected via wordpress-mobile/gutenberg-mobile#4008 (review)
# Conflicts: # Podfile # Podfile.lock
# Conflicts: # Podfile.lock
# Conflicts: # Podfile.lock
To test:
Follow testing instructions from wordpress-mobile/gutenberg-mobile#4008.
NOTE: Only the Instagram embed variant shows up in the block picker when using the installable build, the rest can be tested via the slash inserter.
Regression Notes
Potential unintended areas of impact
The only expected area of impact is the editor and its initialization process.
What I did to test those areas of impact (or what existing automated tests I relied on)
Smoke testing the editor, specifically the following parts:
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.