Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST][DO NOT MERGE][Gutenberg] Embed block: Implement specific Embed preview #16970

Closed
wants to merge 11 commits into from

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Aug 3, 2021

Enables the embed block inline preview to be tested with an installable build.

NOTE: ⚠️ This PR was created for testing purposes only so it shouldn't be merged.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Aug 3, 2021
@fluiddot fluiddot self-assigned this Aug 3, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 3, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 3, 2021

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 54634. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 3, 2021

Warnings
⚠️ This PR is tagged with 'DO NOT MERGE'.

Generated by 🚫 dangerJS

@fluiddot fluiddot closed this Nov 9, 2021
@fluiddot fluiddot deleted the gutenberg/try/embed-block-preview branch November 9, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Status] DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant