-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to manage plugins for self hosted sites that aren't connected to Jetpack #16675
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
WordPress/Classes/Networking/Plugin Management/PluginManagementClient.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/Networking/Plugin Management/SelfHostedPluginManagementClient.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/Networking/Plugin Management/JetpackPluginManagementClient.swift
Outdated
Show resolved
Hide resolved
@emilylaguna , I get a crash when I run on your branch, it has conflicts and irrelevant commits. Can you please fix? |
Interesting! Looks like the Zendesk pod got updated and is causing issue. Fixing it now. |
WordPress/Classes/Networking/Plugin Management/JetpackPluginManagementClient.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/Networking/Plugin Management/PluginManagementClient.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/Networking/Plugin Management/SelfHostedPluginManagementClient.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/Networking/Plugin Management/SelfHostedPluginManagementClient.swift
Outdated
Show resolved
Hide resolved
@leandroalonso I found an issue when installing a plugin the view state would reset and just say 'Install'. I fixed this in this commit: 3c163b8 which pairs the plugin obj with a directory object if it's missing/nil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all the scenarios, all good!
RELEASE-NOTES.txt
Outdated
@@ -1,3 +1,7 @@ | |||
17.7 | |||
----- | |||
* [**] Self hosted sites that do not use Jetpack can now manage (install, modify active, uninstall) their plugins [#16675] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add (Don't apply to Jetpack app)
before the change description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! 426ad9c
Fixes #16595
WordPressKit Related PR: wordpress-mobile/WordPressKit-iOS#406
This adds self hosted non-Jetpack users the ability to manage the plugins on their site.
Demo
plugin-demo.mov
To test:
WordPress Site that is not Jetpack Connected
WordPress Site that is connected to Jetpack
WordPress Hosted Atomic Site
WordPress Hosted Simple Site
WordPress Site that is running WordPress 5.4 or below
Regression Notes
Unit Tests / UI Tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.