Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to manage plugins for self hosted sites that aren't connected to Jetpack #16675

Merged
merged 33 commits into from
Jun 18, 2021

Conversation

emilylaguna
Copy link
Contributor

@emilylaguna emilylaguna commented Jun 11, 2021

Fixes #16595
WordPressKit Related PR: wordpress-mobile/WordPressKit-iOS#406

This adds self hosted non-Jetpack users the ability to manage the plugins on their site.

Demo

plugin-demo.mov

To test:

WordPress Site that is not Jetpack Connected

  1. Switch to the site in the My Site view
  2. Swipe down to find that the Plugin section is visible
  3. Verify you can view your sites plugins
  4. Verify you can make a plugin active
  5. Verify you can deactivate a plugin
  6. Verify you can install a plugin
  7. Verify you can uninstall a plugin

WordPress Site that is connected to Jetpack

  1. Switch to the site in the My Site view
  2. Swipe down to find that the Plugin section is visible
  3. Verify you can view your sites plugins
  4. Verify you can make a plugin active
  5. Verify you can deactivate a plugin
  6. Verify you can install a plugin
  7. Verify you can uninstall a plugin

WordPress Hosted Atomic Site

  1. Switch to the site in the My Site view
  2. Swipe down to find that the Plugin section is visible
  3. Verify you can view your sites plugins
  4. Verify you can make a plugin active
  5. Verify you can deactivate a plugin
  6. Verify you can install a plugin
  7. Verify you can uninstall a plugin

WordPress Hosted Simple Site

  1. Switch to the site in the My Site view
  2. Swipe down to find that the Plugin section is NOT visible

WordPress Site that is running WordPress 5.4 or below

  1. Switch to the site in the My Site view
  2. Swipe down to find that the Plugin section is NOT visible

Regression Notes

  1. Potential unintended areas of impact
  • This affects the logic for showing the Plugin management section
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • Manual testing with each type of site (simple, atomic, self hosted, self hosted running below WordPress 5.5)
  • added unit tests for the plugin management logic
  1. What automated tests I added (or what prevented me from doing so)
    Unit Tests / UI Tests
  • New units tests I added

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 11, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 11, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@emilylaguna emilylaguna modified the milestones: 17.6, 17.7 Jun 11, 2021
Podfile.lock Outdated Show resolved Hide resolved
@yaelirub
Copy link
Contributor

@emilylaguna , I get a crash when I run on your branch, it has conflicts and irrelevant commits. Can you please fix?

@emilylaguna
Copy link
Contributor Author

@emilylaguna , I get a crash when I run on your branch, it has conflicts and irrelevant commits. Can you please fix?

Interesting! Looks like the Zendesk pod got updated and is causing issue. Fixing it now.

@emilylaguna
Copy link
Contributor Author

@leandroalonso I found an issue when installing a plugin the view state would reset and just say 'Install'. I fixed this in this commit: 3c163b8 which pairs the plugin obj with a directory object if it's missing/nil.

Copy link
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the scenarios, all good!

@@ -1,3 +1,7 @@
17.7
-----
* [**] Self hosted sites that do not use Jetpack can now manage (install, modify active, uninstall) their plugins [#16675]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add (Don't apply to Jetpack app) before the change description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 426ad9c

@emilylaguna emilylaguna merged commit 6cf191a into develop Jun 18, 2021
@emilylaguna emilylaguna deleted the task/16595-self-hosted-plugins branch June 18, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable self hosted users to install plugins without needing Jetpack
3 participants