-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.8.1 Hot Fix #16059
16.8.1 Hot Fix #16059
Conversation
These errors are not guarantees that the post cannot be retried so we will not show them for now (an error state will be shown in the post list).
There is no block to replace so we will replace the entire post.
You can trigger an installable build for these changes by visiting CircleCI here. |
This is due to Gutenberg's `replaceBlock` changing the type of the ID field.
Testing ea42a67
|
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested (as mentioned in the above comment) and code looks good (although I'm not too familiar with the Story Editor code).
This is a PR to a hot fix branch to fix an issue with Stories blocks overwriting the contents of a post.
Fixes wordpress-mobile/gutenberg-mobile#3246
Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3246
Gutenberg PR: WordPress/gutenberg#29734
To test:
Changes
replace(blockID: blockID, content: content)
in Gutenberg to replace only the block's content instead of handling the contents of the entire post.Regression Scenarios
New Story Post
New Post with Story block
Editing an existing post
Discarding edits to a post
Discarding edits in Kanvas
PR submission checklist:
RELEASE-NOTES.txt
if necessary.