-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Audio upload processor #15420
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
WordPress/Classes/ViewRelated/Gutenberg/Utils/GutenbergFilesAppMediaSource.swift
Outdated
Show resolved
Hide resolved
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @etoledom! Left a few minor code comments.
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergAudioUploadProcessor.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergAudioUploadProcessor.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergAudioUploadProcessor.swift
Outdated
Show resolved
Hide resolved
…dioUploadProcessor.swift Co-authored-by: Paul Von Schrottky <[email protected]>
…dioUploadProcessor.swift Co-authored-by: Paul Von Schrottky <[email protected]>
…dioUploadProcessor.swift Co-authored-by: Paul Von Schrottky <[email protected]>
Thank you @guarani 🙏 |
gutenberg
PR: WordPress/gutenberg#27401gutenberg-mobile
PR: wordpress-mobile/gutenberg-mobile#2854This PR implements the Audio upload processor to be used together with the Audio block.
This PR also improves the file type filet for the on-device file picker: Now only file extensions allowed by the blog can be picked. Previously any video/image extensions could be picked for the Audio/Video blocks. This is also now used on the Audio block to avoid Apple-only audio filetypes (common on audio files recorded in iPhones).
To test:
Test running metro server on wordpress-mobile/gutenberg-mobile#2854
src
URL is a remote (non-local) URL.cc @jd-alexander
PR submission checklist:
RELEASE-NOTES.txt
if necessary.