-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Enable file block #15400
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
✅ TC001: Upload completes successfully from the device library. |
👋 Hey there! We are freezing |
Updated with the following changes: |
@etoledom could you update the gb mobile submodule to the latest changes here. I appreciate the help. |
✅ Tested again with the new build and everything looks shinny ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etoledom I ran thorough tests using all the latest changes and all the test cases worked as expected.
- ✅ TC001: Upload completes successfully from the device library.
- ✅ TC002: Insert completes successfully from the WordPress Media library.
- ✅ TC003: Upload fails from the device library.
- ✅ TC004: Stop the file upload before it completes.
- ✅ TC005: Close the post with an ongoing file upload.
- ✅ TC006: Replace the selected files.
- ✅ TC007: Change the alignment in the File Block.
- ✅ TC009: Open link in new tab.
- ✅ TC0010: Show/hide download button.
- ✅ TC0011: Copy file URL.
- ✅ TC0012: Close and reopen post with an ongoing file upload.
This PR enables the File Block on the gutenberg block editor.
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.