Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Enable file block #15400

Merged
merged 10 commits into from
Dec 4, 2020
Merged

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Nov 26, 2020

This PR enables the File Block on the gutenberg block editor.

To test:

  • Install the CI build on your device.
  • Follow the manual tests document: TBD

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Nov 26, 2020
@etoledom etoledom self-assigned this Nov 26, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 26, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 26, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@etoledom
Copy link
Contributor Author

✅ TC001: Upload completes successfully from the device library.
✅ TC002: Upload completes successfully from the WordPress Media library.
✅ TC003: Upload fails from the device library.
✅ TC004: Stop the file upload before it completes.
✅ TC005: Close the post with an ongoing file upload.
✅ TC006: Replace the selected files.
✅ TC007: Change the alignment in the File Block.
✅ TC009: Open link in new tab.
✅ TC0010: Show/hide download button.
✅ TC0011: Copy file URL.
✅ TC0012: (Not yet on the document) Close and reopen post with an ongoing file upload.

@jkmassel
Copy link
Contributor

👋 Hey there! We are freezing 16.3 today, so this PR is being bumped to 16.4. If you need it to be part of the 16.3 release, please merge it to the release/16.3 branch and send me a DM – I'll be happy to cut a new beta release!

@jkmassel jkmassel modified the milestones: 16.3, 16.4 Nov 30, 2020
Base automatically changed from gutenberg/after_1.42.0 to develop December 1, 2020 19:50
@etoledom
Copy link
Contributor Author

etoledom commented Dec 3, 2020

Updated with the following changes:
WordPress/gutenberg#27228 (comment)

@jd-alexander
Copy link
Contributor

@etoledom could you update the gb mobile submodule to the latest changes here. I appreciate the help.
WordPress/gutenberg#27228 (comment)
I would, but I am not sure how to generate the bundle. I think I saw the command recently but I haven't used it as yet.

@etoledom
Copy link
Contributor Author

etoledom commented Dec 4, 2020

✅ Tested again with the new build and everything looks shinny ✨

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoledom I ran thorough tests using all the latest changes and all the test cases worked as expected.

  • TC001: Upload completes successfully from the device library.
  • TC002: Insert completes successfully from the WordPress Media library.
  • TC003: Upload fails from the device library.
  • TC004: Stop the file upload before it completes.
  • TC005: Close the post with an ongoing file upload.
  • TC006: Replace the selected files.
  • TC007: Change the alignment in the File Block.
  • TC009: Open link in new tab.
  • TC0010: Show/hide download button.
  • TC0011: Copy file URL.
  • TC0012: Close and reopen post with an ongoing file upload.

@jd-alexander jd-alexander merged commit 81288d2 into develop Dec 4, 2020
@jd-alexander jd-alexander deleted the gutenberg/enable-file-block branch December 4, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants