Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg release 1.33.1 #14599

Merged
merged 5 commits into from
Aug 7, 2020
Merged

Integrate gutenberg release 1.33.1 #14599

merged 5 commits into from
Aug 7, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Aug 7, 2020 •
edited
Loading

This PR incorporates the 1.33.1 release of gutenberg-mobile. For details about the changes included in this PR and testing instructions please see the related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2538

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

guarani and others added 3 commits August 6, 2020 19:49
@guarani
Add hit area to dismiss @-mentions UI
734e492 
When the @-mentions UI is shown in the Gutenberg editor, there is now a hit area above it that is visible no matter what the screen size. This allows the list to be dismissed easily.
@ceyhun
Fix separator appearing like a border in dark mode
2f93ff8
@ceyhun
Update gb-mobile ref
3636194
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 7, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@ceyhun ceyhun mentioned this pull request Aug 7, 2020
Closed
3 tasks
@ceyhun ceyhun added this to the 15.4 ❄️ milestone Aug 7, 2020
@ceyhun ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label Aug 7, 2020
@ceyhun ceyhun mentioned this pull request Aug 7, 2020
Merged
5 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 7, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@guarani
Merge pull request #14598 from wordpress-mobile/fix/suggestion-list-d…
540744f 
…ismiss

Add hit area to suggestions UI to allow dismissing on smaller devices
@guarani
Copy link
Contributor

guarani commented Aug 7, 2020 •
edited
Loading

Tests

@-mentions test cases

  • TC0001
  • TC0002
  • TC0003
  • TC0004
  • TC0005
  • TC0006
  • TC0007
  • TC0008

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website (I noticed an extra list block was created, maybe due to the page's HTML?)
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

@ceyhun ceyhun requested review from guarani and cameronvoell August 7, 2020 14:57
@ceyhun
Copy link
Contributor Author

ceyhun commented Aug 7, 2020

TC001 - Paste formatted text copied from website (I noticed an extra list block was created, maybe due to the page's HTML?)

@guarani I saw the same thing and I remember this didn't happen when I was testing 1.34.0 here. It also didn't create multiple images.

I went and checked again with 1.34.0 (build 32569) and now it's also creating this extra list block and multiple images. I believe in this case it's an HTML change.

@guarani
Copy link
Contributor

guarani commented Aug 7, 2020

I went and checked again with 1.34.0 (build 32569) and now it's also creating this extra list block and multiple images. I believe in this case it's an HTML change.

Thanks for checking @ceyhun, that seemed to be the most likely case (and wrt the multiple images).

I also have another question that maybe you can help answer, does the Pull Quote citation support multiple lines on iOS? The test cases seem to say yes, but I couldn't get it to work.

@ceyhun
Copy link
Contributor Author

ceyhun commented Aug 7, 2020

I also have another question that maybe you can help answer, does the Pull Quote citation support multiple lines on iOS? The test cases seem to say yes, but I couldn't get it to work.

@guarani For me it works, did you try pressing enter in the middle of a caption?

In the test cases it's noted:

On captions, pressing Enter at the end of a caption splits the block, but pressing enter in the middle of a caption's creates a new line.

@ceyhun
Copy link
Contributor Author

ceyhun commented Aug 7, 2020 •
edited
Loading

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website (same as Paul with extra list block and multiple images)
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

Looking good on my side 🎉

@guarani
Copy link
Contributor

guarani commented Aug 7, 2020

@guarani For me it works, did you try pressing enter in the middle of a caption?

That was it 👍 thanks! I think I might have not seen that because it mentions captions and below it's citations, I can fix that in a PR later.

@ceyhun
Copy link
Contributor Author

ceyhun commented Aug 7, 2020

Went over the User Mentions - Test Cases as well and it looks great 🎉

@guarani
Copy link
Contributor

guarani commented Aug 7, 2020

It's looking good from my side as well! 🎉

I can also confirm that after @-mentioning a user, an email is received:
Screen Shot 2020-08-07 at 12 43 08

guarani
guarani approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved! 🎉

@ceyhun ceyhun merged commit 4f04080 into release/15.4 Aug 7, 2020
@ceyhun ceyhun deleted the gutenberg/integrate_release_1.33.1 branch August 7, 2020 17:48
@cameronvoell cameronvoell restored the gutenberg/integrate_release_1.33.1 branch August 7, 2020 21:05
@cameronvoell cameronvoell mentioned this pull request Aug 7, 2020
Merged
3 tasks
@ceyhun ceyhun deleted the gutenberg/integrate_release_1.33.1 branch August 10, 2020 12:34
@guarani guarani mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ceyhun @guarani