Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN] Add Patch to for RCTActionSheetManager.m to have possibility to disable buttons in ActionSheet #14062

Merged
merged 5 commits into from
May 22, 2020
Merged

[RN] Add Patch to for RCTActionSheetManager.m to have possibility to disable buttons in ActionSheet #14062

merged 5 commits into from
May 22, 2020

Conversation

lukewalczak
Copy link
Contributor

Patch RN to have a possibility to disable buttons in the ActionSheetIOS

Ref to gutenberg: WordPress/gutenberg#22132
Ref to gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2220

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak self-assigned this May 6, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 6, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@lukewalczak lukewalczak mentioned this pull request May 6, 2020
Merged
2 tasks
@github-actions
Copy link

github-actions bot commented May 6, 2020 •
edited
Loading

Warnings
⚠️ This PR is tagged with 'DO NOT MERGE'.

Generated by 🚫 dangerJS against 01eb7b6

@lukewalczak lukewalczak force-pushed the patch_rn_for_action_sheet branch 2 times, most recently from d8176b8 to 20514bb Compare May 6, 2020 18:02
@lukewalczak lukewalczak force-pushed the patch_rn_for_action_sheet branch from 20514bb to 01eb7b6 Compare May 6, 2020 18:03
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 6, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@lukewalczak lukewalczak force-pushed the patch_rn_for_action_sheet branch from 8014831 to c5d8f3a Compare May 22, 2020 14:38
@lukewalczak lukewalczak force-pushed the patch_rn_for_action_sheet branch from c5d8f3a to b359306 Compare May 22, 2020 14:39
@geriux geriux self-requested a review May 22, 2020 15:36
@geriux geriux added this to the 15.0 milestone May 22, 2020
geriux
geriux approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it with the Buttons block. ✅

@geriux geriux merged commit b13f48b into develop May 22, 2020
@geriux geriux deleted the patch_rn_for_action_sheet branch May 22, 2020 15:47
@lukewalczak lukewalczak mentioned this pull request May 26, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@lukewalczak lukewalczak

Labels
None yet
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @geriux