Default to Gutenberg upon opening a block based post #12066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
reviewed
Jul 4, 2019
| @@ -7,6 +7,7 @@ import Foundation | |||
| /// list objects. | |||
| protocol KeyValueDatabase { | |||
| func object(forKey defaultName: String) -> Any? | |||
| func bool(forKey: String) -> Bool | |||
There was a problem hiding this comment.
This should be in a protocol extension since it’s just a wrapper that will be the same for all cases
There was a problem hiding this comment.
Nice catch! Updated 👍
koke
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
It works! There is a case that this didn't account for but I think we can live with that. The logic checks if the dialog has been shown, not if the setting has been changed, so the following is possible:
- Install the app
- Go to settings and enable gutenberg
- Try gutenberg for a few things
- Decide you don't want it anymore and disable the app setting
- Open a gutenberg post, the alert shows and gutenberg is enabled again for new posts
Since it seems like an odd case, and it would only happen once, I think it's fine?
… KeyValueDatabase
To describe automatic switch flip to make gutenberg the default editor.
As agreed, we will merge this as a short lived feature, so we won't worry about these edge cases. |
etoledom
added
Gutenberg
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#1186
This PR flips the "default for new posts" switch to true the first time the block editor is launched, if the switch is off.
The alert text was changed to match wordpress-mobile/gutenberg-mobile#1186 (comment)
The logic is:
When the alert is shown, we automatically flip the switch located in App Settings.
This will trigger the tracks event
AppSettingsGutenbergEnabledbut I'd say that it is still desirable, unless we want a new tracks event for this particular case?I'm unsure if we should add this to the release notes.
To test:
UserDefaults.standard.setValue(false, forKey: "Gutenberg.InformativeDialog")to be triggered on app lunch. (onapplicationWillEnterForegroundis helpful to easily reset it)Update release notes:
RELEASE-NOTES.txt.