-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aztec to version 1.7.0 and GB latest (1.7.0) #11885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a couple of issues, but none of those seem to be new, or generated by recent changes on Aztec.
I'm happy to ✅ if these issues will be handled for the future release.
These are the issues in case they are not being tracked:
- UI Api called from background thread when canceling an image upload:
Main Thread Checker: UI API called on a background thread: -[UIApplication statusBarFrame]
PID: 6653, TID: 2439575, Thread name: (none), Queue name: NSManagedObjectContext 0x28246fc00, QoS: 0
Backtrace:
4 WordPress 0x0000000103986f40 -[TracksDeviceInformation statusBarHeight] + 72
5 WordPress 0x000000010398f988 -[TracksService mutableDeviceProperties] + 1016
6 WordPress 0x000000010398d304 -[TracksService trackEventName:withCustomProperties:] + 488
7 WordPress 0x0000000102bafcd4 -[WPAnalyticsTrackerAutomatticTracks track:withProperties:] + 1136
8 WordPress 0x0000000102baf858 -[WPAnalyticsTrackerAutomatticTracks track:] + 56
9 WordPressShared 0x0000000107da6d28 +[WPAnalytics track:] + 308
10 WordPress 0x0000000102c17a58 +[WPAppAnalytics track:] + 60
11 WordPress 0x0000000102bf2830 -[MediaService trackUploadError:] + 116
This is NOT an app crash, but it might randomly actually crash it.
- Merge text into an indented list block results in the cursor jumping to the indented list item:
This is also happening on Web, it might be a desired behavior.
- Block validation Error on Quote block when starting typing on the second line.
- The quote block starts with two empty lines
- Write something in the second leaving the first one empty
- Change to HTML mode
- Block validation will throw an error
This one looks bad, need to investigate more if there is a workaround for it. |
# Conflicts: # Podfile.lock
was this solved @SergioEstevao ? I still see the validation error |
Sorry for the wrong alarm, I don't see it anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm observing the same on WordPress-Android. |
@pinarol does your test post have an image with caption? I only was able to reproduce it when I added an image with multi paragraph caption. Removing it the problem is gone. There might be other instances that generate this issue too. |
@etoledom 👋 here's my post:
Very interesting thing happened: I removed the last block with {"id":1592} and updated the post, problem stopped occurring. When I add it back it started happening again. So I thought there's a problem related with that specific block, but after a few more publishes now I have the block {"id":1592} but I can't see the problem :( Maybe it is not directly related with the post content. Note: I sometimes edit this post from Android also. |
@pinarol thanks for sharing!
Yeah that's also a possibility, or at least not related to a specific kind of content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to find any other problem, LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
To test:
Note: still need to update the release notes, waiting for the final version GB-mobile to know what changed.
Update release notes:
RELEASE-NOTES.txt
.