Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitpack setup #50

Merged
merged 14 commits into from
Oct 11, 2021
Merged

Jitpack setup #50

merged 14 commits into from
Oct 11, 2021

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Oct 7, 2021

This PR makes the project build on Jitpack (log).

The main reason was that Jitpack couldn't seen MediaPicker project as it was defined in settings.gradle as mediapicker. It worked correctly on MacOS but didn't on Linux as Linux is a case-sensitive system. This also made the issue much more difficult to spot.

So to fix the issue and reduce risk of similar issue in future, I've renamed directory to lower-case mediapicker.

Also I've configured maven-publish task and added this configuration to all 3 modules that are meant to be published.

@wzieba wzieba requested a review from 0nko October 7, 2021 16:55
@0nko 0nko self-assigned this Oct 11, 2021
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @wzieba! 🙇‍♂️

@0nko 0nko merged commit 4031888 into trunk Oct 11, 2021
@0nko 0nko deleted the jitpack_setup branch October 11, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants