This repository has been archived by the owner on Feb 6, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Introduce credential manager passkey fetching #132
Merged
ThomazFB
merged 34 commits into
feature-branch/adopt-credential-manager
from
issue/introduce-credential-manager-passkey-fetching
Feb 7, 2024
Merged
Introduce credential manager passkey fetching #132
ThomazFB
merged 34 commits into
feature-branch/adopt-credential-manager
from
issue/introduce-credential-manager-passkey-fetching
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ential-manager-passkey-fetching
Base automatically changed from
issue/add-credential-manager
to
feature-branch/adopt-credential-manager
January 24, 2024 21:25
This was
linked to
issues
Feb 2, 2024
@atorresveiga a follow-up from what we discussed last Thursday, I decided to leave that error handling we talked about to be tackled in #138. The solution is not quite as straightforward as I expected, so I decided to leave to a separate PR. |
1 task
atorresveiga
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Thomaz! The code looks great, and the three testing scenarios work as expected. 🎉
LGTM!
04f2627
into
feature-branch/adopt-credential-manager
8 checks passed
wzieba
pushed a commit
that referenced
this pull request
Oct 15, 2024
…ial-manager-passkey-fetching Introduce credential manager passkey fetching
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issues:
Introduces a rework of the Passkey fetching system inside the Library, where instead of relying to the FIDO2 API, it uses the Credential Manager. This will allow us to properly support Passkeys provided by third-party security services, like 1Password.
Screen capture
Screen_recording_20240201_124606.mp4
How to Test
To make this test scenario possible, make sure you have the following:
Scenario 1 - Login with locally installed Passkey
Use security key
button appears and click on it.Scenario 2 - Login with Passkey provided by 1Password
Use security key
button appears and click on it.Scenario 3 - Login with Passkey provided by another device
Use security key
button appears and click on it.and select the
login with another device` option.Update release notes:
RELEASE-NOTES.txt
if necessary.