-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce credential manager passkey fetching #132
Introduce credential manager passkey fetching #132
Conversation
…ential-manager-passkey-fetching
@atorresveiga a follow-up from what we discussed last Thursday, I decided to leave that error handling we talked about to be tackled in #138. The solution is not quite as straightforward as I expected, so I decided to leave to a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Thomaz! The code looks great, and the three testing scenarios work as expected. 🎉
LGTM!
04f2627
into
feature-branch/adopt-credential-manager
…ial-manager-passkey-fetching Introduce credential manager passkey fetching
Summary
Fix issues:
Introduces a rework of the Passkey fetching system inside the Library, where instead of relying to the FIDO2 API, it uses the Credential Manager. This will allow us to properly support Passkeys provided by third-party security services, like 1Password.
Screen capture
Screen_recording_20240201_124606.mp4
How to Test
To make this test scenario possible, make sure you have the following:
Scenario 1 - Login with locally installed Passkey
Use security key
button appears and click on it.Scenario 2 - Login with Passkey provided by 1Password
Use security key
button appears and click on it.Scenario 3 - Login with Passkey provided by another device
Use security key
button appears and click on it.and select the
login with another device` option.Update release notes:
RELEASE-NOTES.txt
if necessary.