This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Fix issue of deserializing /wp/v2/media response when having an empty media_details.sizes property
#3112
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hichamboushaba
added
[PR] Not Ready for Merge
and removed
[PR] Not Ready for Merge
labels
JorgeMucientes
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing woocommerce/woocommerce-android#12989
This PR adds a fix to the issue of parsing the
/wp/v2/mediaresponse whenmedia_details.sizescontains an array instead of the expected object type.To test: woocommerce/woocommerce-android#12990