[Login] Fix the logic of triggering an SMS OTP #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
force-pushed
the
login/fix-sms-2fa
branch
from
8e85687 to
7d57367
Compare
2 tasks
hichamboushaba
force-pushed
the
login/fix-sms-2fa
branch
from
7d57367 to
2710ee2
Compare
hichamboushaba
changed the title
JorgeMucientes
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in woocommerce/woocommerce-android#12304, we have two issues with SMS 2FA. This PR fixes one of them: fix the broken button to trigger sending an SMS notification, the fix is to indicate that our client supports 2fa by passing the argument
wpcom_supports_2fawith the request.For the second part, I will create a separate PR as involves some changes to the login library, and this fix is the more urgent one as it should unblock the users when attempting to login.
Testing
Please check woocommerce/woocommerce-android#12306