This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Include productId and customerId on order list id #3056
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ThomazFB
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Looks good! Reviewed through woocommerce/woocommerce-android#12094
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces changes to the ListDescriptorUniqueIdentifier calculation to include both productId and customerId fields. This improvement will:
productIdandcustomerId, the identifier will now uniquely represent lists based on these filters. This allows us to determine if cached data can be reused for specific product-customer combinations, potentially reducing API calls.productIdandcustomerIdfilters.Testing
It is better to test this PR using the Woo PR