This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
[Woo] Fix Site Credentials login when site discovery fails and site has http to https redirection #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
force-pushed
the
fix-wpapi-login-http
branch
from
151a623 to
765928e
Compare
1 task
hichamboushaba
commented
Jul 17, 2024
Comment on lines
+13
to
+14
| // TODO investigate the possibility to use `/?rest_route=` instead, | ||
| // `/wp-json` works only when permalinks are enabled, where `/?rest_route=` works without them |
There was a problem hiding this comment.
I added this TODO to keep track of the explained issue, I also logged this Github issue to keep track of it woocommerce/woocommerce-android#12043
JorgeMucientes
approved these changes
Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: woocommerce/woocommerce-android#11931
This PR updates the logic of site discovery used to infer the
SiteModel#wpApiRestUrlto usehttpsby default when the automatic discovery fails, this fixes login issues for sites with non-working discovery (non-standardLinkheader) andhttptohttpsredirection, for more information, please check peaMlT-Kc-p2For tests, please check the PR woocommerce/woocommerce-android#12033