This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Post conflict resolution for self-hosted sites #2990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the modifications needed for the new post conflict handling for the self-hosted sites that use XML-RPC calls. We are adding the
if_not_modified_since
parameter to the wp.edit call so we can get the 409 error code when there is a more recent revision of the post that we try to update.Specs pcdRpT-5ID-p2#comment-9638.
WP Companion PR: wordpress-mobile/WordPress-Android#20651
To Test:
Test Post version forced write on top of web (existing logic)
sync_publishing
flag and restart the appTest Post version did not write on top of web (new logic)
sync_publishing
flag and restart the appTest Conflict Resolution dialog is shown
Regression Notes
Potential unintended areas of impact
The post is not updated properly
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
Relied upon existing automated post tests
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones): No UI components were changed with this PR