Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real requests to fetch Blaze payment methods as well as create a Blaze campaign #2977

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

JorgeMucientes
Copy link
Contributor

@JorgeMucientes JorgeMucientes commented Mar 19, 2024

Description

Replaces usage of mocked responses for Blaze campaign creation flow. Specifically:

  • Replaces create campaign mocked responses with the new create campaign endpoint
  • Replaces fetching payment methods mocked response with real request

Additionally, it adds a couple of model changes required to support the latest API format.

To test the changes, use this PR: woocommerce/woocommerce-android#11112

NOTE: We won't be able to test this now, as the API is not ready yet. But we can start merging it as these changes are not breaking changes and are hidden behind a feature flag.

@JorgeMucientes JorgeMucientes changed the title Use real request to fetch Blaze payment methods as well as create a Blaze campaign Use real requests to fetch Blaze payment methods as well as create a Blaze campaign Mar 19, 2024
@JorgeMucientes JorgeMucientes marked this pull request as ready for review March 19, 2024 09:19
@0nko 0nko self-assigned this Mar 21, 2024
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@0nko 0nko merged commit 3d20859 into trunk Mar 21, 2024
14 checks passed
@0nko 0nko deleted the issue/10722-replace-mocked-requests branch March 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants