Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations to support order deletion from the app #2972

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Mar 12, 2024

To support deleting orders from the app, we need to handle deletion in a cancellable way (a way that supports undoing by the user), this PR adds two changes to support this:

  1. Update the order list descriptor to support excluding specific orders.
  2. Delete the Order summary DB entity when an order is deleted.
Testing

Please check woocommerce/woocommerce-android#11068

@hichamboushaba hichamboushaba changed the title Helper function to support cancellable order deletion Preparations to support order deletion from the app Mar 13, 2024
@hichamboushaba hichamboushaba marked this pull request as ready for review March 13, 2024 17:09
@0nko 0nko self-assigned this Mar 13, 2024
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the associated WCAndroid PR and everything's working well.. :shipit:

@hichamboushaba hichamboushaba merged commit 54e2405 into trunk Mar 14, 2024
14 checks passed
@hichamboushaba hichamboushaba deleted the order-deletion branch March 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants