Xmlrpc login errors. #2280
Merged
Xmlrpc login errors. #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 tasks
khaykov
approved these changes
Feb 11, 2022
| @@ -14,6 +15,23 @@ public static SiteError genericToSiteError(BaseNetworkError error) { | |||
| break; | |||
| } | |||
| } | |||
| return new SiteError(errorType, error.message); | |||
|
|
|||
| SiteError siteError = new SiteError(errorType, error.message); | |||
There was a problem hiding this comment.
A very minor NP - maybe we can avoid a double initialization of siteError here? If it makes sense :)
1 task
|
Looks like there are no changes since my review, so good to go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: this is ready to be reviewed; but since it has implications for Woo as well, keeping it as a draft so it is not accidentally merged before the validation from WPAndroid and WooAndroid point of view.
This is part of 12401 issue.
I tried to keep the current behaviors not affected, only adding a couple of enums mapping the various errors conditions for xml-rpc, that are used/parsed only in the login flow for self-hosted for now. This should reduce the possibility of regressions but appreciate testing of the various log-in/sign-up scenarios 🙇 .
See the companion WPMobile PR for more details.