MSD - Stats Card - Handle Error Inside Cards Response #2251
Conversation
(TDD) Tests will fail at this point
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
@ashiagr All looks good. The initial data values have been set to “0” and “empty” as we discussed. The errors are specific to the card type and embedded as such, In addition the errors will flow through to the client. Even if we only show a generic card today, we are ready to handle the specific errors in the future.
Tests work as expected. +1
…o issue/15749-msd-todays-stats-handle-error-response # Conflicts: # fluxc/src/main/java/org/wordpress/android/fluxc/network/rest/wpcom/dashboard/CardsRestClient.kt
…o issue/15749-msd-todays-stats-handle-error-response # Conflicts: # example/src/test/java/org/wordpress/android/fluxc/network/rest/wpcom/dashboard/CardsRestClientTest.kt # fluxc/src/main/java/org/wordpress/android/fluxc/network/rest/wpcom/dashboard/CardsRestClient.kt
…o issue/15749-msd-todays-stats-handle-error-response # Conflicts: # example/src/test/java/org/wordpress/android/fluxc/store/dashboard/CardsStoreTest.kt
…o issue/15749-msd-todays-stats-handle-error-response
|
@ashiagr - I retested this PR using WPAndroid#[15893 ](MSD - Handle Single Dashboard Card Error in UI). I was able to see the stats card properly AND no stats card when using a site in which I don't have permission to view stats. I intercepted the response to verify this. I'm going to leave the merging for you because I'm not 100% sure which PRs need to go first. |
ashiagr
deleted the
issue/15749-msd-todays-stats-handle-error-response
branch
Parent wordpress-mobile/WordPress-Android#15749
This draft PR:
today's statsandpostscards responses to include error.today's statsandpostscard model to include error.To test:
CardsRestClientandCardsStoreclasses and make sure that the accompanying tests are working as expected.Notes:
fetchCardsendpoint is not replaced withv1_1version yet to avoid rest route not found errors.fetchCardsendpoint withv1_1version.WordPress-AndroidPR is up and we've tested cards with errors feature.