Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Aztec to v1.3.24 and Gutenberg to v1.2.1 #9638

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Update Aztec to v1.3.24 and Gutenberg to v1.2.1 #9638

merged 2 commits into from
Apr 17, 2019

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Apr 16, 2019 •
edited
Loading

This PR updates the gutenberg-mobile reference to point to the latest patch release, v1.2.1 and updating Aztec.

The reference is currently pointing to the release/1.2.1 branch on https://github.com/wordpress-mobile/gutenberg-mobile.

ToDo

  • When that gets merged to gutenberg-mobile master, I'll update the ref here to point to the merge commit.

To test:
The block editor should work as normal.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor added Aztec Gutenberg Editing and display of Gutenberg blocks. labels Apr 16, 2019
@jtreanor jtreanor added this to the 12.2 ❄️ milestone Apr 16, 2019
@jtreanor jtreanor mentioned this pull request Apr 16, 2019
Merged
@jtreanor jtreanor changed the title Update Aztec to v1.3.24 and Gutenverg to v1.2.1 Update Aztec to v1.3.24 and Gutenberg to v1.2.1 Apr 16, 2019
@mzorz mzorz mentioned this pull request Apr 17, 2019
Closed
19 tasks
@jtreanor jtreanor changed the base branch from develop to release/12.2 April 17, 2019 13:22
@jtreanor jtreanor force-pushed the gb/update-aztec-gutenberg-mobile-v1.2.1 branch from d6f64c2 to f612980 Compare April 17, 2019 13:23
@mzorz
Copy link
Contributor

mzorz commented Apr 17, 2019

Smoke tested, found these 2 issues:

  1. Caret / focus position when adding page break block gutenberg-mobile#882
  2. the red screen being fixed in Add requestMediaImport method to the Android bridge gutenberg-mobile#864 is still there so, we need to cherry pick
    (discussed with @jtreanor, reflecting here for history purposes)

@mzorz
Copy link
Contributor

mzorz commented Apr 17, 2019

tested again with latest commit - works as expected 👌

mzorz
mzorz approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtreanor jtreanor merged commit 7bfacb4 into release/12.2 Apr 17, 2019
@jtreanor jtreanor deleted the gb/update-aztec-gutenberg-mobile-v1.2.1 branch April 17, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

Assignees
No one assigned
Labels
Aztec Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
12.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jtreanor @mzorz