Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Twitter publicize connections #9629

Merged
merged 4 commits into from
Apr 16, 2019
Merged

Fixes Twitter publicize connections #9629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c9e5d6
Don't send the external user id for new twitter publicize connections
oguzkocer Apr 15, 2019
a227772
Add release note for the Twitter publicize connection fix
oguzkocer Apr 15, 2019
dc81204
Address a possible NPE in string comparison for twitter publicize action
oguzkocer Apr 16, 2019
d61c67c
Merge remote-tracking branch 'origin/develop' into issue/8652-fix-pub…
oguzkocer Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* Redirect to username/password login when WordPress.com reports email login not allowed
* Updated notifications list to Material guidelines
* Updated snackbar design to Material guidelines
* Fixed an issue with Twitter publicize connections
* Fixed an issue where the site icon wasn't updating correctly after switching to another site

12.2
Expand Down
3 changes: 2 additions & 1 deletion WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeActions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ public void onErrorResponse(VolleyError volleyError) {

Map<String, String> params = new HashMap<>();
params.put("keyring_connection_ID", Long.toString(keyringConnectionId));
if (!externalUserId.isEmpty()) {
// Sending the external id for Twitter connections result in an error
if (!TextUtils.isEmpty(externalUserId) && !PublicizeConstants.TWITTER_ID.equals(serviceId)) {
params.put("external_user_ID", externalUserId);
}
String path = String.format(Locale.ROOT, "/sites/%d/publicize-connections/new", siteId);
Expand Down
1 change: 1 addition & 0 deletions WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ public class PublicizeConstants {

public static final String GOOGLE_PLUS_ID = "google_plus";
public static final String FACEBOOK_ID = "facebook";
public static final String TWITTER_ID = "twitter";

public enum ConnectAction {
CONNECT,
Expand Down