Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point gutenberg mobile ref to v1.1.0 #9385

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Mar 8, 2019

This PR updates the gutenberg-mobile reference to point to the latest release, v1.1.0. No wpandroid integration changes introduced.

The reference is currently pointing to the release/1.1.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: [https://github.com/wordpress-mobile/gutenberg-mobile/pull/726).

When that gets merged to gutenberg-mobile master, I'll update the ref here to point to the merge commit.

To test:
The block editor should work as normal.

Update release notes:

  • If there are user-facing changes, I have added an item to RELEASE-NOTES.txt.

@marecar3 marecar3 requested a review from mzorz March 8, 2019 17:55
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 8, 2019

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@marecar3 marecar3 added the Gutenberg Editing and display of Gutenberg blocks. label Mar 8, 2019
@marecar3 marecar3 self-assigned this Mar 8, 2019
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, been testing this for a while, tried:

  1. writing
  2. publishing
  3. modifying
  4. updating
  5. turning airplane mode on/off
  6. rotating.
  7. opening a large GB post.
  8. uploading media in various ways

All of this seems to be generally working 👍

I can see the title height change on my phone although it's minor (not abrupt as it was before the fix).

I had a crash once, when opening a post with an image block I had just uploaded, and rotating the device while the Editor loader spinner was being shown (https://gist.github.com/mzorz/10a4e975ad130141437d485051227ab2). It happened only after switching back to classic on long posts, and it was an OOM that I couldn't really reproduce without doing the Aztec dance so, I'll give it the go.

I noticed that opening a post with any content, then rotating the device, will produce a new action in the undo/redo history. Opened an issue with that wordpress-mobile/gutenberg-mobile#727, as it's not a blocker for this PR.

LGTM :shipit:

@marecar3
Copy link
Contributor Author

marecar3 commented Mar 8, 2019

Thanks @mzorz !

@mzorz
Copy link
Contributor

mzorz commented Mar 8, 2019

Re-tested after the hash was updated, all looks good here @marecar3 ! :shipit:

@marecar3 marecar3 merged commit fc1561e into develop Mar 8, 2019
@marecar3 marecar3 deleted the gb/point-to-gutenberg-mobile-v1.1.0 branch March 8, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants