-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] media upload progress reattach #9129
Merged
mzorz
merged 12 commits into
gb/feature_upload_media_file
from
gb/media_upload_progress_reattach
Jan 28, 2019
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6a1f764
tracking upload progress reattachment caps and sending signals down t…
mzorz 6f36735
updated gb-mobile hash
mzorz f72ca20
fixed merge conflict
mzorz b1bb3d1
Merge remote-tracking branch 'origin/gb/feature_upload_media_file' in…
mzorz 063cbf1
implemented hasFailedMediaUploads
mzorz 5cc9e25
updated gb-mobile hash for upload progress reattachment
mzorz 23b4236
added OnReattachQueryListener interface to bring up the latest upload…
mzorz 92437c5
fixed merge conflict
mzorz 610f195
updated gutenberg-mobile hash
mzorz f96c564
fixed merge conflict
mzorz 54ef201
remove max upload progress value tracking once file finishes uploading
mzorz 6cb4c90
moved callback handling code to updateMediaProgress() to tidy up
mzorz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule gutenberg-mobile
updated
5 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to use interface
Set
instead ofHashSet
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, just copied the code to represent the same functionality we had as parity with Aztec from here https://github.com/wordpress-mobile/WordPress-Android/blob/develop/libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/AztecEditorFragment.java#L172