Remove android.permission.SYSTEM_ALERT_WINDOW in release builds #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtreanor
force-pushed
the
react-native-permissions
branch
from
33dc325 to
7fac7b2
Compare
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native adds permissions that are only needed for debug purposes in all builds.
android.permission.SYSTEM_ALERT_WINDOWis used for the debug overlay so can be removed for release builds.The react native issue is facebook/react-native#5886.
To test:
./gradlew assembleVanillaDebug assembleVanillaReleaseandroid.permission.SYSTEM_ALERT_WINDOWwithapkanalyzer manifest permissions WordPress/build/outputs/apk/vanilla/debug/WordPress-vanilla-debug.apkandroid.permission.SYSTEM_ALERT_WINDOWwithapkanalyzer manifest permissions WordPress/build/outputs/apk/vanilla/release/WordPress-vanilla-release.apk