Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar count issue with traffic chart #20475

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Mar 14, 2024

This fixes the bar count on the Traffic tab when "By month" is selected.

before after

To Test:

  1. Log in.
  2. Open "My Site → Stats"
  3. Select "By month" granularity.
  4. Select the previous month by tapping < button.
  5. Verify that there is the correct number of bars on the chart.
  6. Repeat 4 and 5 for more months.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@irfano irfano added this to the 24.5 milestone Mar 14, 2024
@irfano irfano requested a review from ravishanker March 14, 2024 17:56
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.5. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20475-bb577fd
Commitbb577fd
Direct Downloadjetpack-prototype-build-pr20475-bb577fd.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20475-bb577fd
Commitbb577fd
Direct Downloadwordpress-prototype-build-pr20475-bb577fd.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 40.42%. Comparing base (b3c7fcf) to head (bb577fd).

Files Patch % Lines
...h/lists/sections/traffic/TrafficOverviewUseCase.kt 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20475      +/-   ##
==========================================
- Coverage   40.44%   40.42%   -0.02%     
==========================================
  Files        1462     1462              
  Lines       67241    67261      +20     
  Branches    11176    11179       +3     
==========================================
  Hits        27193    27193              
- Misses      37573    37593      +20     
  Partials     2475     2475              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ravishanker ravishanker merged commit 22edd92 into trunk Mar 14, 2024
20 of 24 checks passed
@ravishanker ravishanker deleted the fix/bar-count-issue-with-traffic-chart branch March 14, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants