Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up the bar animation on the TRAFFIC tab #20391

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Mar 2, 2024

This speeds up the bar animation of the chart on the TRAFFIC tab.
Related discussion: p1709280694061749/1709217317.772089-slack-C06BR07TJHK

before video
before.webm
after video
after.webm

To Test:

  1. Log in.
  2. Enable stats_traffic_tab from "Me → Debug settings"
  3. Open the TRAFFIC tab from "My Site → Stats".
  4. Notice the animation speed of the chart is faster.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Animation speed is not worth testing.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.4. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20391-9e03331
Commit9e03331
Direct Downloadjetpack-prototype-build-pr20391-9e03331.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20391-9e03331
Commit9e03331
Direct Downloadwordpress-prototype-build-pr20391-9e03331.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Have you played with 500 millis? Anything that moves draws attention, in this case the graph.

@ravishanker ravishanker merged commit 81cc154 into trunk Mar 3, 2024
19 of 23 checks passed
@ravishanker ravishanker deleted the feature/speed-up-bar-animation branch March 3, 2024 01:02
@irfano
Copy link
Member Author

irfano commented Mar 3, 2024

Have you played with 500 millis? Anything that moves draws attention, in this case the graph.

Yes, I tried 500 millis, but it seemed too slow to me. Chris mentioned that this animation may worsen the experience of comparing. I didn't want to remove it entirely but rather to increase speed. I think that with 250 millis, the speed matches that of animation seen on the web stats.

Thank you for your quick review!

@irfano irfano added the Stats label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants