-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the loading state of the traffic chart #20390
Conversation
This just reformats the code without introducing any changes.
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20390 +/- ##
=======================================
Coverage 40.15% 40.15%
=======================================
Files 1476 1476
Lines 68275 68272 -3
Branches 11329 11329
=======================================
Hits 27417 27417
+ Misses 38349 38346 -3
Partials 2509 2509 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this 👍
This fixes the loading state of the chart on the TRAFFIC tab.
Before,
UiModelMapper
was mapping models to Success even though the state was LOADING. This caused bars to animate with the current data unnecessarily before animating with the new data.before video
before.webm
after video
after.webm
To Test:
stats_traffic_tab
off.Regression Notes
Potential unintended areas of impact
stats_traffic_tab
feature.What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: