Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the loading state of the traffic chart #20390

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Mar 2, 2024

This fixes the loading state of the chart on the TRAFFIC tab.
Before, UiModelMapper was mapping models to Success even though the state was LOADING. This caused bars to animate with the current data unnecessarily before animating with the new data.

before video
before.webm
after video
after.webm

To Test:

  1. Log in.
  2. Open the TRAFFIC tab from "My Site → Stats".
  3. Change the selected date by tapping the left arrow.
  4. Verify that there is no unnecessary loading animation for bars.
  5. Navigate back.
  6. Open "Me → Debug settings"
  7. Switch stats_traffic_tab off.
  8. Repeat 2-3.
  9. Verify there is no issue with loading graphs and stats cards.

Regression Notes

  1. Potential unintended areas of impact

    • Disabled state of stats_traffic_tab feature.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Tested manually.
  3. What automated tests I added (or what prevented me from doing so)

    • This simple logic change is not worth automated tests.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@irfano irfano added this to the 24.4 milestone Mar 2, 2024
@irfano irfano changed the title Fix the loading state of the traffic chart. Fix the loading state of the traffic chart Mar 2, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.4. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20390-c069412
Commitc069412
Direct Downloadjetpack-prototype-build-pr20390-c069412.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20390-c069412
Commitc069412
Direct Downloadwordpress-prototype-build-pr20390-c069412.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 40.15%. Comparing base (4dfebc9) to head (c069412).

Files Patch % Lines
...ss/android/ui/stats/refresh/lists/UiModelMapper.kt 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #20390   +/-   ##
=======================================
  Coverage   40.15%   40.15%           
=======================================
  Files        1476     1476           
  Lines       68275    68272    -3     
  Branches    11329    11329           
=======================================
  Hits        27417    27417           
+ Misses      38349    38346    -3     
  Partials     2509     2509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 👍

@ravishanker ravishanker merged commit a1cdc18 into trunk Mar 3, 2024
19 of 24 checks passed
@ravishanker ravishanker deleted the fix/loading-state-of-traffic-chart branch March 3, 2024 01:00
@irfano irfano added the Stats label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants