-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lib] Update tracks targetSdk version from 33 to 34. #20364
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Damn. Just realized I didn't add a review 🤦🏻 |
👋 @notandyvee - Update Milestone to 24.6 since it seems not ready nor required for 24.5 |
Hey @ravishanker . It was ready. But tracks needs to be reviewed first. You can review here: Automattic/Automattic-Tracks-Android#200 |
Quality Gate passedIssues Measures |
Found 1 violations: The PR caused some dependency changes (expand to see details)
+--- project :libs:analytics
-| \--- com.automattic:Automattic-Tracks-Android:3.5.0
+| \--- com.automattic:Automattic-Tracks-Android:3.6.0
+--- project :libs:editor
-| \--- com.automattic:Automattic-Tracks-Android:3.5.0 (*)
+| \--- com.automattic:Automattic-Tracks-Android:3.6.0 (*)
-\--- com.automattic:Automattic-Tracks-Android:{strictly 3.5.0} -> 3.5.0 (*)
+\--- com.automattic:Automattic-Tracks-Android:{strictly 3.6.0} -> 3.6.0 (*)
Please review and act accordingly
|
Appreciate the review @ravishanker . Updated the tracks update. If you could just 🚬 test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes #20360
This PR updates tracks so it's ready for Android 14 update. The
targetSdk
is updated from 33 to 34.Note
To Test:
🚬 Smoke test the app. Filter the logcat by "track" so you can see the tracks logs working.
Regression Notes
Potential unintended areas of impact
All tracks logs.
What I did to test those areas of impact (or what existing automated tests I relied on)
🚬 Smoke test.
What automated tests I added (or what prevented me from doing so)
n/a
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.