Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lib] Update tracks targetSdk version from 33 to 34. #20364

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

notandyvee
Copy link
Contributor

@notandyvee notandyvee commented Mar 1, 2024

Fixes #20360


This PR updates tracks so it's ready for Android 14 update. The targetSdk is updated from 33 to 34.

Note

To Test:

🚬 Smoke test the app. Filter the logcat by "track" so you can see the tracks logs working.


Regression Notes

  1. Potential unintended areas of impact

    All tracks logs.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    🚬 Smoke test.

  3. What automated tests I added (or what prevented me from doing so)

    n/a


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 1, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20364-a0da3ba
Commita0da3ba
Direct Downloadjetpack-prototype-build-pr20364-a0da3ba.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 1, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20364-a0da3ba
Commita0da3ba
Direct Downloadwordpress-prototype-build-pr20364-a0da3ba.apk
Note: Google Login is not supported on these builds.

@notandyvee
Copy link
Contributor Author

Damn. Just realized I didn't add a review 🤦🏻

@notandyvee notandyvee removed the request for review from irfano March 15, 2024 21:07
@ravishanker ravishanker modified the milestones: 24.5, 24.6 Mar 17, 2024
@ravishanker
Copy link
Contributor

👋 @notandyvee - Update Milestone to 24.6 since it seems not ready nor required for 24.5

@notandyvee
Copy link
Contributor Author

Update Milestone to 24.6 since it seems not ready nor required for 24.5

Hey @ravishanker . It was ready. But tracks needs to be reviewed first. You can review here: Automattic/Automattic-Tracks-Android#200

@notandyvee notandyvee requested a review from ravishanker March 26, 2024 18:09
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 +--- project :libs:analytics
-|    \--- com.automattic:Automattic-Tracks-Android:3.5.0
+|    \--- com.automattic:Automattic-Tracks-Android:3.6.0
 +--- project :libs:editor
-|    \--- com.automattic:Automattic-Tracks-Android:3.5.0 (*)
+|    \--- com.automattic:Automattic-Tracks-Android:3.6.0 (*)
-\--- com.automattic:Automattic-Tracks-Android:{strictly 3.5.0} -> 3.5.0 (*)
+\--- com.automattic:Automattic-Tracks-Android:{strictly 3.6.0} -> 3.6.0 (*)

Please review and act accordingly

@notandyvee
Copy link
Contributor Author

Appreciate the review @ravishanker . Updated the tracks update. If you could just 🚬 test.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ravishanker ravishanker merged commit 7ff5847 into trunk Mar 27, 2024
21 checks passed
@ravishanker ravishanker deleted the andy/tracks-android-14-update branch March 27, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Tracks to Android 14
3 participants