Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the visibility issue with the menu button on the stats #20175

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Feb 12, 2024

This fixes the visibility issue with the menu button on the stats. Before, the menu button was visible even on granular tabs. Now, it will only be visible on the INSIGHTS tab.

before after

A single approval is sufficient.


To reproduce the issue, you should open the stats screen when the initially selected screen is a granular tab.

To Test:

  1. Log in.
  2. Open stats.
  3. Verify that the menu button is visible when the INSIGHTS tab is selected.
  4. Navigate to DAYS tab or any other granular tabs.
  5. Verify that the menu button is no longer visible.
  6. Navigate back to the home screen.
  7. Open stats again.
  8. Verify that the menu button is not visible when a granular tab is selected.
  9. Navigate to the INSIGHTS tab.
  10. Verify that the menu button is visible.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Nothing
  3. What automated tests I added (or what prevented me from doing so)

    • None. This is a minor issue. It isn't worth a specific UI test case.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@irfano irfano added this to the 24.3 milestone Feb 12, 2024
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20175-43f642b
Commit43f642b
Direct Downloadjetpack-prototype-build-pr20175-43f642b.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20175-43f642b
Commit43f642b
Direct Downloadwordpress-prototype-build-pr20175-43f642b.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spotting, and fixing it 🚀

This was an existing issue. Happens when on a granular tab in Stats, navigate back to dashboard, and then return to Stats again immediately. The menu icon gear appears on that granular tab!

@ravishanker ravishanker merged commit a8f4a27 into trunk Feb 12, 2024
20 checks passed
@ravishanker ravishanker deleted the fix/menu-visibility-on-stats branch February 12, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants