Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra space between my site today's stats and lower optional message #19414

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

justtwago
Copy link
Contributor

@justtwago justtwago commented Oct 19, 2023

I noticed that the Today's Stats card doesn't contain a bottom padding, which makes the card look ugly. It occurs when the optional get_more_views_message message is invisible.

Before After

To test:

  • Go to My Site tab and select any site with some statistics
  • Make sure the Today's Stats card has proper bottom content padding

Regression Notes

  1. Potential unintended areas of impact
    NaN

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    NaN

  3. What automated tests I added (or what prevented me from doing so)
    NaN

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19414-5649751
Commit5649751
Direct Downloadwordpress-prototype-build-pr19414-5649751.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19414-5649751
Commit5649751
Direct Downloadjetpack-prototype-build-pr19414-5649751.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @justtwago 🙇
The code changes LGTM and the app behaves as expected on my Pixel 5 (Android 14) 🎉

No audience before No audience after
noaudience_before noaudience_after
Audience before Audience after
audience_before audience_after

@antonis antonis added this to the 23.6 milestone Oct 20, 2023
@antonis antonis merged commit 5366a61 into trunk Oct 20, 2023
@antonis antonis deleted the fix/todays-stats-card-bottom-padding branch October 20, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants