-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add close button to site creation checkout #19411
Add close button to site creation checkout #19411
Conversation
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr19411-576c221 | |
Commit | 576c221 | |
Direct Download | wordpress-prototype-build-pr19411-576c221.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr19411-576c221 | |
Commit | 576c221 | |
Direct Download | jetpack-prototype-build-pr19411-576c221.apk |
handle cancel checkout
Actually, there's an exit flow already that can be used. It already asks if they want to exit, and lands back on site list. ![]() Pushed a commit, not sure, which one would work best though |
The dialog on the progress screen mentions, "You may lose your progress," but when coming back from the checkout, the site has already been created. I believe that closing the checkout screen without displaying an additional dialog is currently a better approach. This is also consistent with how it is handled on iOS.
I have made the necessary changes to address this. Can you please review it again, @ravishanker? |
remove redundant test since flow is changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This adds a close button to the checkout page in the site creation flow. If the close button is tapped, the purchase will be canceled, and the site will be created.
Screen_recording_20231019_014356.mp4
To test:
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
Nothing
What automated tests I added (or what prevented me from doing so)
This is not a good case for an automated test.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: