Plans in Site Creation: Fix for the free domain name from the Calypso popup

[irfano]

This improves the plans in the site creation flow. If a domain from the plan selection screen was received (via redirect_url), it will be used for creating the cart.

Important

Before testing and merging this PR, the Automattic/wp-calypso#83045 must be merged.

• fa8a6b4: productName was unnecessary, so I removed it.
• 0be3bc1: Added a domainName parameter to CreateSite event.
• 43f7f4e: domain_name from redirect_url is passed to the CreateSite event. It's null if redirect_url does not return any domain. In that case, the domain from the domain selection will be used.

To test:

Site creation with a free domain and free plan

1. Launch JP app
2. Go to Me-> Debug settings
3. Switch to the Remote Feature tab, find plans_in_site_creation, and enable it
4. Switch to My Site tab
5. Tap the down arrow to the right of the site name on the My Site screen
6. Tap the + icon at the top right on the Site picker screen
7. Select ⊕ Create WordPress.com site on the modal dialog
8. Tap Skip at the top right on the first step (topic screen)
9. Tap Skip at the top right on the next step (theme screen)
10. Enter a search query (whatever you want here)
11. Select a free domain (should be *.wordpress.com)
12. Verify Plans screen opens with Personal, Premium, Business, and Ecommerce plans
13. Select the free plan
14. Verify it returns to the site setup screen
15. Verify a site is created with the desired domain

Also, test these cases

• Site creation with a paid domain and paid plan
• Site creation with a paid domain and free plan
  • From popup, select the free plan
  • From popup, select the paid plan

Regression Notes

1. Potential unintended areas of impact
   This may break different flow in site creation checkout flow

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Tested manually

3. What automated tests I added (or what prevented me from doing so)
   This only updates the current behavior, no automated test was added.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19391-3ed6555
	Commit	3ed6555
	Direct Download	jetpack-prototype-build-pr19391-3ed6555.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19391-3ed6555
	Commit	3ed6555
	Direct Download	wordpress-prototype-build-pr19391-3ed6555.apk

Note: Google Login is not supported on these builds.

[ravishanker]

@irfano - Tested it after merging Calypso PR. Please feel free to merge this. Give a final spin of the other PR before merging that too. 👍

[ravishanker]

LGTM 👍