-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plans in site creation flow #19377
Merged
ravishanker
merged 5 commits into
trunk
from
feature/improve-plans-in-site-creation-flow
Oct 15, 2023
Merged
Improve plans in site creation flow #19377
ravishanker
merged 5 commits into
trunk
from
feature/improve-plans-in-site-creation-flow
Oct 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Base automatically changed from
Plans-in-site-creation-Plan-Selection-Screen
to
trunk
October 15, 2023 16:44
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Update steps to handle plan selection only when plan in site creation is enabled
ravishanker
approved these changes
Oct 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this 👍
Fixed an issue with flow steps, with plans appearing even when feature is not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues and improves the code from #19304
paid_domain_name
parameter in the redirect URL. Therefore, I used the viewmodel's domain name to pass it to the next screen.appendQueryParameter
into already openedapply
scope.plan_id
andplan_slug
parameters were unnecessary when loading the plan selection link; they are being used only in redirect URLs.To test:
Site creation with a free domain and free plan
Regression Notes
Potential unintended areas of impact
This may affect the plan selection screen in the site creation flow.
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually.
What automated tests I added (or what prevented me from doing so)
I haven't added any automated test since this is an improvement PR for another PR.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: