-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Dashboard: Quick Start Support #19318
Unified Dashboard: Quick Start Support #19318
Conversation
…ocus is an interim step, not the active task
…ask. More tap is an interim step, not the active task
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
…on to activityNavigator
… the tutorial shows when on the more menu
…nlde QuickStartEvent
…s quickStartEvent to the viewmodel
Generated by 🚫 dangerJS |
…art snackbars within more menu
…ckbars, so a hook is needed to properly show.This is a lightweight implementation to support unified dashboard quick start.
…ng into the composeSnackbarCallback in SnackbarSequencer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zwarm
I have tested the quick start tasks and everything looks good to me. I can see as you mentioned that the icon is not shown as you mentioned + quick start wont prompt the user when in the more view.
We can re-visit this later and try to fix it. Approving and merging this PR
ab0351c
into
UI-Modernization-Remove-tabs-and-update-quick-links-layout
Parent #19270
This PR refactors quick start to support the more menu
Main Changes
QuickStartRepository
to include a new mutableLiveData<QuickStartMenuStep?> which will be observed inMySiteViewModel
and passed along toQuickLinksItemViewModelSlice
and used to show the More focus pointQuickStartRepository.setActiveTask
to take in a boolean indicating if this is being called from the more menu. This prevents it from looping again through task being set to pending instead of activeSnackbarSequencer
that will post the snackbar back to listeners. This will be picked up inMenuActivity
; which will create a lightweight message to be displayed.NOTES:
SnackbarSequencer
, the icon has already been merged with the message and there is no opportunity to pull it out.SnackbarManager
interface an two implementations:ComposeSnackbarManager
andTraditionalSnackbarManager
. The managers would implement their own logic for creating snackbars, but use the single queue inSnackbarSequencer
. The type of data class in the queue should change to something more generic so both managers can create the proper snackbar.To test:
Regression Notes
Potential unintended areas of impact
Quick Start does not work properly
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and added new unit tests
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: N/A