-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Dashboard: Menu UI cleanup #19289
Unified Dashboard: Menu UI cleanup #19289
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zwarm
Everything looks good to me.
There is a minor issue that I can see with RTL, The Back arrow is not correct in Menu screen on RTL. I think MainTopAppBar
is not implemented to handle the RTL. I can see the incorrect back arrow in screens which are using MainTopAppBar
. We can take up in a seperate PR but I wanted to bring it up so that you are aware of this.
Approving and Merging this PR
fce47fa
into
UI-Modernization-Remove-tabs-and-update-quick-links-layout
Parent #19270
This PR applies the following the the Menu view
To test:
Regression Notes
Potential unintended areas of impact
The menu looks poorly
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so) N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: