Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Dashboard: Menu UI cleanup #19289

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Oct 1, 2023

Parent #19270

This PR applies the following the the Menu view

  • Updates general spacing/styling of items
  • Adjusts the way the CustomXMLWidgetView is composed to reserve resources
  • Extracts the composables out of the activity, but remains in the same fil
  • Adds RTL support
  • Create MenuItemState and swap that in for MySiteCardAndItem
  • Add base unit tests for MenuViewModel

To test:

  • Install the app
  • Login and select a site
  • Navigate to Quick Links Card > More
  • ✅ Verify the view loads correctly and look good
  • ✅ Verify the view looks the same in dark and light mode
  • Change the app language to a RTL language (hebrew works great)
  • ✅ Verify the view looks is shown RTL
  • Go through the remainder of the UI checklist and verify all works as expected

Regression Notes

  1. Potential unintended areas of impact
    The menu looks poorly

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@zwarm zwarm requested a review from AjeshRPai October 1, 2023 19:30
@zwarm zwarm self-assigned this Oct 1, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 1, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19289-830b991
Commit830b991
Direct Downloadwordpress-prototype-build-pr19289-830b991.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 1, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19289-830b991
Commit830b991
Direct Downloadjetpack-prototype-build-pr19289-830b991.apk
Note: Google Login is not supported on these builds.

@zwarm zwarm added this to the 23.5 milestone Oct 1, 2023
@zwarm zwarm marked this pull request as ready for review October 1, 2023 21:31
Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zwarm

Everything looks good to me.

There is a minor issue that I can see with RTL, The Back arrow is not correct in Menu screen on RTL. I think MainTopAppBar is not implemented to handle the RTL. I can see the incorrect back arrow in screens which are using MainTopAppBar. We can take up in a seperate PR but I wanted to bring it up so that you are aware of this.

Approving and Merging this PR

@AjeshRPai AjeshRPai self-requested a review October 3, 2023 12:20
@AjeshRPai AjeshRPai merged commit fce47fa into UI-Modernization-Remove-tabs-and-update-quick-links-layout Oct 3, 2023
@AjeshRPai AjeshRPai deleted the issue/19270-menu-ui-cleanup branch October 3, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants