Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements: the QuickStartFocus Point in more menu #19282

Conversation

AjeshRPai
Copy link
Contributor

@AjeshRPai AjeshRPai commented Sep 29, 2023

Part of #19270

Description

Feature Flag

  • Removes - Feature Flag
    • MySiteDashboardTabsFeatureConfig
    • QuickStartExistingUsersV2FeatureConfig
  • Removes Build Config
    • QUICK_START_EXISTING_USERS_V2
    • ENABLE_MY_SITE_DASHBOARD_TABS
    • MY_SITE_DASHBOARD_TABS

Quick Link Item

  • Implements the Logic to show quick start focus point in more menu
  • Implements the logic to fetch quick links when site is changed
  • Disabled Primary icon tint according to list item action (blaze)
  • RTL support
  • Updates the padding and spacing
  • Updates the classess name from QuickLinkRibbon to QuickLinkItem

General fixes

  • Implements the OnResume which was missing from MySiteFragment

To test:

  1. Go to dashboard
  2. Create a Site or Login to a site with quick start in progress
  3. Click on Check Stats or Review Pages or Social Sharing
  4. Notice that the quick start focus point is shown in more

Regression Notes

  1. Potential unintended areas of impact
    Login or Dashboard is not working properly

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and Unit testing

  3. What automated tests I added (or what prevented me from doing so)
    Unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 29, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19282-96fbfa6
Commit96fbfa6
Direct Downloadjetpack-prototype-build-pr19282-96fbfa6.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 29, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19282-96fbfa6
Commit96fbfa6
Direct Downloadwordpress-prototype-build-pr19282-96fbfa6.apk
Note: Google Login is not supported on these builds.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 29, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@zwarm zwarm marked this pull request as ready for review September 29, 2023 11:46
- The quick start focus point show/hide was dependent on the active
quick link items, which is incorrect. Irregardless if the list item
 is in quick links or not, the quick start focus point should be shown
 on more quick link
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjeshRPai - Looks good. Thanks for taking care of those minor issues. I tested quick start focus points on the More button, the refreshing of the shortcuts on site change, no-sites user does not crash on login, and the card shows RTL languages.

@zwarm zwarm requested a review from a team as a code owner September 29, 2023 17:14
@zwarm zwarm merged commit 307358a into UI-Modernization-Remove-tabs-and-update-quick-links-layout Sep 29, 2023
@zwarm zwarm deleted the issue/19270-quick-start-in-menu branch September 29, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants