-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements: the QuickStartFocus Point in more menu #19282
Merged
zwarm
merged 23 commits into
UI-Modernization-Remove-tabs-and-update-quick-links-layout
from
issue/19270-quick-start-in-menu
Sep 29, 2023
Merged
Implements: the QuickStartFocus Point in more menu #19282
zwarm
merged 23 commits into
UI-Modernization-Remove-tabs-and-update-quick-links-layout
from
issue/19270-quick-start-in-menu
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 dangerJS |
- The quick start focus point show/hide was dependent on the active quick link items, which is incorrect. Irregardless if the list item is in quick links or not, the quick start focus point should be shown on more quick link
zwarm
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AjeshRPai - Looks good. Thanks for taking care of those minor issues. I tested quick start focus points on the More button, the refreshing of the shortcuts on site change, no-sites user does not crash on login, and the card shows RTL languages.
zwarm
merged commit Sep 29, 2023
307358a
into
UI-Modernization-Remove-tabs-and-update-quick-links-layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19270
Description
Feature Flag
Quick Link Item
QuickLinkRibbon
toQuickLinkItem
General fixes
To test:
Regression Notes
Potential unintended areas of impact
Login or Dashboard is not working properly
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and Unit testing
What automated tests I added (or what prevented me from doing so)
Unit tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: