Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Dashboard: Menu view adjustments #19280

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Sep 29, 2023

Parent #19270

DO NOT MERGE - this is possibly a bad idea. The UI changes have been stripped into a separate PR. Consider this PR a POC for quick start

This PR applies the following the the Menu

  • Styling of items
  • Extracts the composable out of the activity

TODO

  • Create a separate state instead of passing the ListItem itself
  • RTL Support
  • Hook in quick start using event bus
  • Scroll to menu item
  • Add RTL support

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@zwarm zwarm added this to the 23.5 milestone Sep 29, 2023
@zwarm zwarm requested a review from AjeshRPai September 29, 2023 00:11
@zwarm zwarm self-assigned this Sep 29, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 29, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19280-eeaf6f7
Commiteeaf6f7
Direct Downloadwordpress-prototype-build-pr19280-eeaf6f7.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 29, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19280-eeaf6f7
Commiteeaf6f7
Direct Downloadjetpack-prototype-build-pr19280-eeaf6f7.apk
Note: Google Login is not supported on these builds.

@zwarm zwarm marked this pull request as ready for review September 29, 2023 12:06
@zwarm zwarm added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Oct 1, 2023
@zwarm
Copy link
Contributor Author

zwarm commented Oct 3, 2023

Not proceeding with this PR. It turned into a POC only

@zwarm zwarm closed this Oct 3, 2023
@zwarm zwarm removed this from the 23.5 milestone Oct 3, 2023
@zwarm zwarm deleted the issue/19270-menu-refactoring branch October 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Personalization Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants