Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements: the quick link item logic in Unified Menu #19279

Merged
merged 22 commits into from
Sep 28, 2023
Merged

Implements: the quick link item logic in Unified Menu #19279

merged 22 commits into from
Sep 28, 2023

Conversation

AjeshRPai
Copy link
Contributor

@AjeshRPai AjeshRPai commented Sep 28, 2023 •
edited
Loading

Part of #19270

Description

This PR implements

  1. Show the quick links according to the personalization of shortcuts
  2. Adds QuicklinksViewModelSlice to fetch and handle the clicks

Test

  1. Go to dashboard
  2. Click on Personalize your home tab button
  3. Go to Shortcuts Personalization
  4. Add/Remove the shortcuts
  5. Go to dashboard
  6. Refresh the screen
  7. Verify that the changes are reflected and quick links are shown/hidden

Regression Notes

  1. Potential unintended areas of impact
    Quick links are not shown in dashboard

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing & Unit testing

  3. What automated tests I added (or what prevented me from doing so)
    Unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@AjeshRPai
+ Adds: a ListItemActionHandler to handle the click on list item
b3edf8f
@AjeshRPai
+ Adds: List action handler to handle the site items click
214f8f3
@AjeshRPai
+ Adds: QuickLinksItemViewModelSlice
b64dde3 
+ Adds: QuickLinksItemViewModelSlice to show the logic of active
quick links
@AjeshRPai
- Removes: redundantQuickLinkRibbonBuilder.kt
0a4ce6c
@AjeshRPai
- Removes: QuickLinkRibbonBuilder from card builder
e7f2e0d
@AjeshRPai
↑ Updates: the viewholder to remove stats,pages and media focus points
140e896
@AjeshRPai
↑ Updates: the SiteItemsViewModelSlice to use list action handler
15afb80
@AjeshRPai
↑ Updates: the MenuViewModel to use list action handler
f3b0d6b
@AjeshRPai
↑ Updates: the quick link ribbon to remove pages,stats and media QS
953e61f
@AjeshRPai
+ Adds: QuickLinkRibbonViewModelSlice to MySiteViewModel
f52c0f6 
+ Adds: QuickLinkRibbonViewModelSlice to MySiteViewModel
@AjeshRPai
* Fixes: tests in CardBuilderTest
f39164c
@AjeshRPai AjeshRPai added this to the 23.4 milestone Sep 28, 2023
@AjeshRPai AjeshRPai requested a review from zwarm September 28, 2023 13:05
@AjeshRPai AjeshRPai self-assigned this Sep 28, 2023
Base automatically changed from issue/19270-unified-menu-refactorings to UI-Modernization-Remove-tabs-and-update-quick-links-layout September 28, 2023 13:35
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 28, 2023 •
edited
Loading

Warnings
⚠️ PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 28, 2023 •
edited
Loading

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19279-0c9f8c6
Commit0c9f8c6
Direct Downloadjetpack-prototype-build-pr19279-0c9f8c6.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 28, 2023 •
edited
Loading

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19279-0c9f8c6
Commit0c9f8c6
Direct Downloadwordpress-prototype-build-pr19279-0c9f8c6.apk
 Note: Google Login is not supported on these builds.

@AjeshRPai
- Removes: quick link ribbon builder test
36c3294
@AjeshRPai
- Removes: quick link ribbon builder tests and dependencies
11fed00
@AjeshRPai
Merge branch 'UI-Modernization-Remove-tabs-and-update-quick-links-lay…
edbd988 
…out' into issue/19270-quick-link-ribbon-builder

# Conflicts:
#	WordPress/src/test/java/org/wordpress/android/ui/mysite/MySiteCardAndItemTest.kt
@AjeshRPai AjeshRPai marked this pull request as ready for review September 28, 2023 16:12
@zwarm
Refactor: replace requireNotNull with a let check; because quickLinks…
5ac37d9 
…Items can be null when we are in a no-site situation
@zwarm
Refactor: update tests to support quickLinksViewModelSlice, remove qu…
0c9f8c6 
…ick link navigation tests, and general cleanup of unnecc stubbings.
@zwarm zwarm self-requested a review September 28, 2023 21:42
@zwarm zwarm modified the milestones: 23.4, 23.5 Sep 28, 2023
zwarm
zwarm approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 All works as expected @AjeshRPai . Navigation works from the quick links ribbon card and from the Menu view. 🙇

@zwarm zwarm added the 1 label Sep 28, 2023
@zwarm zwarm merged commit 15a45f2 into UI-Modernization-Remove-tabs-and-update-quick-links-layout Sep 28, 2023
@zwarm zwarm deleted the issue/19270-quick-link-ribbon-builder branch September 28, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwarm zwarm zwarm approved these changes

Assignees

@AjeshRPai AjeshRPai

Labels
My Site Dashboard
Projects
None yet
Milestone
23.5
Development

Successfully merging this pull request may close these issues.
3 participants
@AjeshRPai @wpmobilebot @zwarm